[BEAM-7791] Provision datasources and dashboards from config. #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been away from Beam development for a few months. Would you mind finding a different reviewer? Let me know if you have specific questions or if there's a particular piece you think requires my review. |
|
@swegner |
|
R: @rohdesamuel |
rohdesamuel
reviewed
Jul 29, 2019
rohdesamuel
reviewed
Jul 29, 2019
.test-infra/metrics/grafana/dashboards/stability_critical_jobs_status.json
Outdated
Show resolved
Hide resolved
rohdesamuel
approved these changes
Jul 29, 2019
Ardagan
force-pushed
the
ProvisionDashboards
branch
from
ed6739e
to
abad431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change in this PR is to make git a source of truth for Grafana dashboards. This is handled mostly in grafana/Dockerfile
Side changes are:
Second step planned is to update dashoards release process. I'll update docs once second step is done.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.