[BEAM-7856] Suppress error on table bigquery table already exists #9204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @chamikaramj |
|
Ping for the review |
|
Passing the review to Pablo. |
chamikaramj
reviewed
Aug 6, 2019
| schema=schema or found_table.schema, | ||
| additional_parameters=additional_create_parameters) | ||
| except HttpError as exn: | ||
| if exn.status_code == 409: |
There was a problem hiding this comment.
Instead of suppressing the error, can we move table creation to a step that preceeds writing ? That seems cleaner.
Java SDK seems to be doing something like this based on a quick look:
There was a problem hiding this comment.
I agree, Using a single element transform to create the table would be idle.
|
LGTM for getting this in as a short term fix. But prob. file a JIRA for a proper fix. |
angoenka
commented
Aug 14, 2019
There was a problem hiding this comment.
Thanks!
I have added comment in the jira https://issues.apache.org/jira/browse/BEAM-7856 and kept it open.
| schema=schema or found_table.schema, | ||
| additional_parameters=additional_create_parameters) | ||
| except HttpError as exn: | ||
| if exn.status_code == 409: |
There was a problem hiding this comment.
I agree, Using a single element transform to create the table would be idle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.