[BEAM-7862] Moving FakeBigQueryServices to published artifacts #9206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r: @amaliujia |
pabloem
commented
Aug 5, 2019
| @@ -65,7 +65,7 @@ | |||
| * <p>Some BigQuery types are duplicated here since slightly different Avro records are produced | |||
| * when exporting data in Avro format and when reading data directly using the read API. | |||
| */ | |||
| public static final ImmutableMultimap<String, Type> BIG_QUERY_TO_AVRO_TYPES = | |||
There was a problem hiding this comment.
This is an immutable map that we'd rather not expose in the API, so making sure to make it non-public.
amaliujia
approved these changes
Aug 6, 2019
| @@ -269,6 +269,12 @@ public static Schema fromTableSchema(TableSchema tableSchema) { | |||
| return fromTableFieldSchema(tableSchema.getFields()); | |||
| } | |||
|
|
|||
| /** Convert a list of BigQuery {@link TableFieldSchema} to Avro {@link org.apache.avro.Schema}. */ | |||
| public static org.apache.avro.Schema toGenericAvroSchema( | |||
There was a problem hiding this comment.
Why adding an extra call?
There was a problem hiding this comment.
This call works as proxy to BigQueryAvroUtils, which is not a public class, so it's not accessible from other packages. I did not want to make the whole class public, so instead I added this call to BigQueryUtils, which is a public class with similar calls for schema conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.