[BEAM-7899] Fix Python Dataflow VR tests by specify sdk_location #9269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python Dataflow ValidatesRunner |
udim
reviewed
Aug 6, 2019
| @@ -70,6 +70,7 @@ task postCommitIT(dependsOn: ['installGcpTest', 'sdist']) { | |||
| def testOpts = basicTestOpts + ["--attr=IT"] | |||
| def cmdArgs = project.mapToArgString(["test_opts": testOpts, | |||
| "worker_jar": dataflowWorkerJar, | |||
| "sdk_location": "${project.buildDir}/apache-beam.tar.gz", | |||
There was a problem hiding this comment.
This affects Python 2 postcommits, but that job was not broken.
How did it work?
There was a problem hiding this comment.
The default path build/apache-beam.tar.gz is used which is output of :sdks:python:sdist and happens to be a dependency task of PostCommit_Py2. If you look at timeline of this job, sdks:python:sdist is executed before postCommitIT so when postCommitIT runs, the tarball is ready.
|
run python 2 postcommit |
|
python2 postcommit passed https://builds.apache.org/job/beam_PostCommit_Python2_PR/55/. PTAL @udim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to explicitly set
sdk_locationfor Python2 dataflow VR tests after moved them totest-suites/dataflow/py2. The default valuebuild/apache-beam.tar.gzis still in use which is incorrect.Following change should fix the failure.
+R: @udim
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.