-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax upper bound for dill #9419
Conversation
Dill now has a 0.3.0 version. Could not find any release notes to tell whether there are any breaking changes or not. (Asked here: uqfoundation/dill#223)
Run Portable_Python PreCommit |
The change looks fine, let's see if we get any response about the release notes. |
Run Python 2 PostCommit |
cc: @tvalentyn |
Run Python 2 PostCommit |
Run Python 3.5 PostCommit |
Run Python 3.6 PostCommit |
Run Python 3.7 PostCommit |
Dataflow Jobs are failing with a strange error: Workflow failed. Causes: Because of the shape of your pipeline, the Cloud Dataflow job optimizer produced a job graph that is not updatable using the --update pipeline option. This is a known issue that we are working to resolve. See https://issuetracker.google.com/issues/118375066 for information about how to modify the shape of your pipeline to avoid this error. You can override this error and force the submission of the job by specifying the --experiments=allow_non_updatable_job parameter., The stateful transform named 'WriteToBigQuery/BigQueryBatchFileLoads/ImpulseSingleElementPC/Decode Values.out/FromValue/ReadStream' is in two or more computations. |
@tvalentyn could you take over this PR? I do not see the same issue in other postcommit tests. It could be a flake or somehow related to dill upgrade. I am not sure how. /cc @angoenka since there is an streaming update related error here. |
@aaltay https://github.com/cloudpipe/cloudpickle has a changelog. 😉 |
Thank you @Peque . We are also considering switching to cloudpickle. (@tvalentyn is there an issue tracking that investigation?) |
We started to consider a switch to cloudpickle along the sidelines of several issues, but it makes sense to dedicate an issue of its own to this migration, opened https://issues.apache.org/jira/browse/BEAM-8123. |
Dataflow errors on this PR occurred in postcommit test suites last week, I think they are not specific to this change. |
Run Python 2 PostCommit |
Run Python 3.7 PostCommit |
Run Python 3.5 PostCommit |
Run Python 3.6 PostCommit |
Run Python 3.5 PostCommit |
Run Python 3.6 PostCommit |
Dill now has a 0.3.0 version. Could not find any release notes to tell whether there are any breaking changes or not. (Asked here: uqfoundation/dill#223)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.