[BEAM-8111] Add ValidatesRunner test to AvroSchemaTest #9454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Dataflow ValidatesRunner |
TheNeuralBit
force-pushed
the
dataflow-schema-test
branch
from
48c695e
to
d7db5b3
Compare
TheNeuralBit
changed the title
|
Run Dataflow ValidatesRunner |
This reverts commit fb93067.
|
Run Dataflow ValidatesRunner |
TheNeuralBit
changed the title
|
R: @reuvenlax |
|
did you verify that this test would've caught the regression? |
|
Yeah I ran the Dataflow validates runner tests on commit fb93067 Here's the Jenkins run: https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_PR/100/ |
markflyhigh
added a commit
that referenced
this pull request
Sep 11, 2019
…t to AvroSchemaTest" This reverts commit 58a12b6.
soyrice
pushed a commit
to soyrice/beam
that referenced
this pull request
Sep 19, 2019
…to AvroSchemaTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ValidatesRunner test to AvroSchemaTest that would have caught BEAM-8111.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.