[BEAM-5539] Upgrade google-cloud-pubsub and bigtable packages. #9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python PreCommit |
1 similar comment
|
Run Python PreCommit |
|
R: @chamikaramj |
udim
force-pushed
the
pubsub-upgrade
branch
from
43282ea
to
2c165f7
Compare
|
s/bigquery/bigtable in title. |
udim
changed the title
udim
force-pushed
the
pubsub-upgrade
branch
from
2c165f7
to
a0e02ab
Compare
done |
|
LGTM. I'm not sure about current integration test coverage of Cloud BT sink. Please make sure this change is captured by some test suite. |
|
There are no bigtable tests except the IT, and it's broken. I'll hold off on this PR for now. |
|
Changed https://issues.apache.org/jira/browse/BEAM-7611 to a blocker. Either we have to enable tests or manually try to run a pipeline that uses BigTable sink to verify that the new dependency does not cause a regression. |
|
Run Portable_Python PreCommit |
|
I hacked bigtableio_it.py locally to fix pickling issues and ran it on direct and Dataflow runners successfully. |
|
run python 2 postcommit |
|
Thanks. Merging. |
3 tasks
markflyhigh
added a commit
that referenced
this pull request
Sep 16, 2019
…google-cloud-pubsub and bigtable packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.