[BEAM-6158] Temporarily remove super() calls in Beam examples. #9513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Portable_Python PreCommit |
tvalentyn
force-pushed
the
dofn_ptransform_super_cleanup
branch
from
ada5737
to
deff3d2
Compare
tvalentyn
changed the title
…ass in Beam examples.
tvalentyn
force-pushed
the
dofn_ptransform_super_cleanup
branch
from
deff3d2
to
ccac658
Compare
aaltay
approved these changes
Sep 10, 2019
|
Thanks for review, @aaltay . I also verified batch mobile gaming examples on Python 3 with Dataflow runner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several Beam examples define custom transforms and DoFns with customized
__init__, that calls superclass constructor.Due to BEAM-6158
super()in main session calls currently don't pickle on Python 3. In this PR we replace these calls with invocation of parent constructor (DoFn, or PTransform). Strictly speaking, it is not the same as invokingsuper(), since super delegates the calls to next class parent in__mro__chain, however this change would make it easier for users to experiment and try Beam examples on Python 3 until BEAM-6158 is addressed, and in simple class hierarchies it results in the same behavior.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.