Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[BEAM-5878] support DoFns with Keyword-only arguments" #9517

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Revert "[BEAM-5878] support DoFns with Keyword-only arguments" #9517

merged 1 commit into from
Sep 9, 2019

Conversation

tvalentyn
Copy link
Contributor

Reverts #9237

@tvalentyn
Copy link
Contributor Author

R: @lazylynx

@tvalentyn
Copy link
Contributor Author

tvalentyn commented Sep 9, 2019 •
edited
Loading

R: @chamikaramj

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

To clarify, I believe this is being reverted since the monkey patch caused some user pipelines to fail with an infinite recursion.

@chamikaramj chamikaramj merged commit a757475 into master Sep 9, 2019
@tvalentyn
Copy link
Contributor Author

Thanks @chamikaramj . Reasons for revert were also discussed on the original PR.

@iemejia iemejia deleted the revert-9237-support_keyword-only-arguments branch January 17, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tvalentyn @chamikaramj