Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-8178] Fix broken Load Tests running on Flink #9521

Merged
merged 1 commit into from Sep 16, 2019
Merged

[BEAM-8178] Fix broken Load Tests running on Flink #9521

merged 1 commit into from Sep 16, 2019

Conversation

kamilwu
Copy link
Contributor

@kamilwu kamilwu commented Sep 9, 2019 •
edited

The following set of load tests:

https://builds.apache.org/view/A-D/view/Beam/view/All/job/beam_LoadTests_Python_Combine_Flink_Batch/
https://builds.apache.org/view/A-D/view/Beam/view/All/job/beam_LoadTests_Python_coGBK_Flink_Batch/
https://builds.apache.org/view/A-D/view/Beam/view/All/job/beam_LoadTests_Python_GBK_Flink_Batch/

is broken due to the #9351 and #9487 being merged. This PR fixes the issue.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Seed Job

1 similar comment
@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Load Tests Python CoGBK Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Load Tests Python GBK Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Load Tests Python CoGBK Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 9, 2019

Run Load Tests Python GBK Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 10, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 10, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu kamilwu marked this pull request as ready for review September 10, 2019 08:43
@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 10, 2019

R: @pabloem Could you take a look?

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 12, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 12, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 12, 2019

Run Seed Job

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 12, 2019

Run Load Tests Python Combine Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 12, 2019

Run Load Tests Python CoGBK Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 12, 2019

Run Load Tests Python GBK Flink Batch

@kamilwu
Copy link
Contributor Author

kamilwu commented Sep 16, 2019

R: @lgajowy

lgajowy
lgajowy approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@lgajowy lgajowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgajowy lgajowy merged commit d3ffdce into apache:master Sep 16, 2019
@kamilwu kamilwu deleted the python-image-names-fix branch September 16, 2019 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgajowy lgajowy lgajowy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilwu @lgajowy