Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7911] Fix flakiness in avroio_test.py #9554

Merged
merged 1 commit into from Sep 12, 2019
Merged

Conversation

udim
Copy link
Member

@udim udim commented Sep 11, 2019

  • Comparison data[last_char_index] == b'B' was never true in Py3 (LHS
    is int, RHS is bytes).
  • Fix assertion on exception text.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@udim
Copy link
Member Author

udim commented Sep 11, 2019

R: @aaltay

Copy link
Member

@aaltay aaltay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

If the condition was never true, why the test was flaky? Should not it always fail?

@udim
Copy link
Member Author

udim commented Sep 12, 2019

This LGTM.

If the condition was never true, why the test was flaky? Should not it always fail?

It was intentionally corrupting data by replacing the last byte. It was failing to corrupt the data in 1 out of 256 cases, where the last byte was already 'B'.

@aaltay
Copy link
Member

aaltay commented Sep 12, 2019

This LGTM.
If the condition was never true, why the test was flaky? Should not it always fail?

It was intentionally corrupting data by replacing the last byte. It was failing to corrupt the data in 1 out of 256 cases, where the last byte was already 'B'.

Ack. Thank you for the fix. Much cleaner.

- Comparison `data[last_char_index] == b'B'` was never true in Py3 (LHS
  is int, RHS is bytes).
- Fix assertion on exception text.
@udim udim merged commit ec7a3d2 into apache:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants