Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7389] Generate notebook for filter #9561

Merged
merged 2 commits into from Sep 14, 2019

Conversation

davidcavazos
Copy link
Contributor

@davidcavazos davidcavazos commented Sep 12, 2019

First PR introducing the script to generate notebooks from docs using the Filter page as an example.

R: @aaltay [script/code]
R: @rosetn [writing/formatting]

Staged: http://apache-beam-website-pull-requests.storage.googleapis.com/9561/documentation/transforms/python/elementwise/filter/index.html
Notebook: https://colab.research.google.com/github/davidcavazos/beam/blob/notebook-filter/examples/notebooks/documentation/transforms/python/element-wise/filter-py.ipynb

This is using the newly created md2ipynb package to generate the notebook files from Markdown. It's importing the license and setup instructions which are not present in the source Markdown docs, but needed in the notebook. It also adds links to back to the docs.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aaltay aaltay merged commit 6b5084b into apache:master Sep 14, 2019
@davidcavazos davidcavazos deleted the notebook-filter branch September 16, 2019 06:55
soyrice pushed a commit to soyrice/beam that referenced this pull request Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants