Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8223] Fix version number in gradle.properties for 2.16 release #9569

Merged
merged 1 commit into from Sep 16, 2019

Conversation

markflyhigh
Copy link
Contributor

We should not include -SNAPSHOOT and .dev in version number for our release. This is a manul fix to 2.16.0 release branch. We should also fix the release automation script in the future.

+cc: @Hannah-Jiang


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@markflyhigh
Copy link
Contributor Author

+R: @yifanzou @lukecwik

@Hannah-Jiang
Copy link
Contributor

Hannah-Jiang commented Sep 13, 2019

What is impact of this change?
I agree that we need to make the version consistent. We wanted to tackle it later, not as part of 2.16, so I added a new variable(python_sdk_version). If you confirmed all the impact of this change, I am OK with this change.

@markflyhigh
Copy link
Contributor Author

Synced with Hannah offline. It's not about consistent naming between java's version and python's python_sdk_version. The problem this PR trying to fix is that we should not use dev version number in our release.

Test failure comes from Dataflow service side. I'll go ahead and merge it.

@markflyhigh markflyhigh merged commit 4c0840e into apache:release-2.16.0 Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants