Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-1080] Add test for versioned encoding #9573

Merged
merged 1 commit into from
Sep 15, 2019
Merged

[BEAM-1080] Add test for versioned encoding #9573

merged 1 commit into from
Sep 15, 2019

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Sep 15, 2019

No description provided.

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2019

Run Python PreCommit

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2019

Run Portable_Python PreCommit

2 similar comments
@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2019

Run Portable_Python PreCommit

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2019

Run Portable_Python PreCommit

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2019

The new test passes. Portable Precommit is broken on master, so ignoring for now.

@pabloem
Copy link
Member Author

pabloem commented Sep 15, 2019

r: @Drake8710 from contributor workshop

Drake8710
Drake8710 approved these changes Sep 15, 2019
View reviewed changes
Copy link

@Drake8710 Drake8710 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pabloem pabloem merged commit b9de43c into apache:master Sep 15, 2019
@pabloem pabloem deleted the BEAM-1080 branch September 15, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drake8710 Drake8710 Drake8710 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pabloem @Drake8710