[BEAM-8279] Disable IOTypeHints.from_callable #9611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run python 3.7 postcommit |
|
Run Python PreCommit |
robertwb
approved these changes
Sep 19, 2019
| @@ -121,6 +121,8 @@ def foo((a, b)): | |||
|
|
|||
| _ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...] | |||
| _ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any] | |||
| # TODO(BEAM-8280): Remove this when from_callable is ready to be enabled. | |||
| _enable_from_callable = False | |||
There was a problem hiding this comment.
Nit: the name "from_callable" isn't very enlightening without context, perhaps something more descriptive like infer_types_from_annotations?
There was a problem hiding this comment.
Sorry I don't have time to make this change. I'll be away for 1.5 weeks starting tomorrow.
|
I believe the failure in sdks:python:test-suites:tox:py2:docs is unrelated |
I've already tested some internal tests that weren't passing and they pass, but I haven't done a clean import without my changes. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.