[BEAM-8311] Cherry-pick Merge pull request #9601, #9656: Minor fix for python mongodbio display data #9655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @markflyhigh |
|
Run Python PreCommit |
1 similar comment
|
Run Python PreCommit |
pabloem
reviewed
Sep 25, 2019
| @@ -204,7 +205,7 @@ def display_data(self): | |||
| res['collection'] = self.coll | |||
| res['filter'] = self.filter | |||
| res['project'] = self.projection | |||
There was a problem hiding this comment.
Do you need to convert the projection as well?
There was a problem hiding this comment.
yes, this is included in #9656 and I'm gonna cherry-pick separately
There was a problem hiding this comment.
or actually I think we can merge two in this.
[BEAM-8311] Fix py mongodbio display data
y1chi
changed the title
y1chi
changed the title
markflyhigh
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.