[BEAM-8318] Adds a pipeline option to Python SDK for controlling the number of threads per worker. #9675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @aaltay |
angoenka
reviewed
Sep 27, 2019
| @@ -680,6 +680,16 @@ def _add_argparse_args(cls, parser): | |||
| 'enabled with this flag. Please sync with the owners of the runner ' | |||
| 'before enabling any experiments.')) | |||
|
|
|||
| parser.add_argument( | |||
| '--number_of_worker_threads', | |||
There was a problem hiding this comment.
It will be good to keep the name same as in JRH getNumberOfWorkerHarnessThreads
There was a problem hiding this comment.
Done. And also updated documentation about limited availability of the option (currently only when experiment 'use_unified_worker' is set).
aaltay
approved these changes
Sep 27, 2019
threads per worker.
chamikaramj
force-pushed
the
add_num_threads_per_worker_option
branch
from
9b0f06e
to
c5bbb51
Compare
|
Thanks. @angoenka PTAL. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be similar to following already available for Java SDK.
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java#L178
Currently, only works for DataflowRunner on Fn API path.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.