[BEAM-5878] update dill min version to 0.3.1.1 and add test for functions with Keyword-only arguments #9686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python PreCommit |
lazylynx
changed the title
|
Run Python PreCommit |
|
Hi @lazylynx , could you please give this PR another try after resolving conflicts? We should have fixed the test failures now. |
|
@tvalentyn Sure. Wait for a while. |
lazylynx
force-pushed
the
support_keyword-only-arguments_with_latest_dill
branch
2 times, most recently
from
e58f715
to
14e1d7a
Compare
tvalentyn
reviewed
Nov 4, 2019
sdks/python/setup.py
Outdated
| @@ -106,8 +106,7 @@ def get_version(): | |||
| 'avro>=1.8.1,<2.0.0; python_version < "3.0"', | |||
| 'avro-python3>=1.8.1,<2.0.0; python_version >= "3.0"', | |||
| 'crcmod>=1.7,<2.0', | |||
| # Dill doesn't guarantee comatibility between releases within minor version. | |||
| 'dill>=0.3.0,<0.3.1', | |||
| 'dill>=0.3.1.1,<0.4.0', | |||
There was a problem hiding this comment.
Let's restrict this to < 0.3.2 due to possible backwards-incompatibility issues.
There was a problem hiding this comment.
Also, please keep the comment, and link uqfoundation/dill#347 in the comment. Thank you.
lazylynx
force-pushed
the
support_keyword-only-arguments_with_latest_dill
branch
from
14e1d7a
to
1142fb3
Compare
…ions with kwonly args
lazylynx
force-pushed
the
support_keyword-only-arguments_with_latest_dill
branch
from
1142fb3
to
0834b41
Compare
lazylynx
changed the title
|
Sorry, I referenced a wrong Dill issue in my last comment, I meant to link uqfoundation/dill#341. I'll add a commit to this branch to fix this. |
|
Merging since the tests passed on 0834b41, and second commit does not affect any tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update dill minimum version to 0.3.1.1 in setup.py and re-add unittest for keyword-only arguments from #9237
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.