Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8339] Quietly skip cleanup_pubsub in automation script #9719

Merged
merged 1 commit into from Oct 3, 2019

Conversation

markflyhigh
Copy link
Contributor

We don't want to fail the automation script if we cleanup topic/subscription that doesn't exist. Make them quietly pass instead.

+R: @yifanzou


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

We don't want to fail the automation script if we cleanup topic/subscription that doesn't exist. Make them quietly pass instead.
@markflyhigh markflyhigh changed the title Quietly skip cleanup_pubsub in automation script [BEAM-8339] Quietly skip cleanup_pubsub in automation script Oct 2, 2019
Copy link
Contributor

@yifanzou yifanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markflyhigh
Copy link
Contributor Author

PythonLint failure is unrelated.

@markflyhigh markflyhigh merged commit 7e65dc8 into master Oct 3, 2019
@iemejia iemejia deleted the markflyhigh-patch-3 branch January 17, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants