Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8368] Avoid libprotobuf-generated exception when importing apache_beam #9768

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

kamilwu
Copy link
Contributor

@kamilwu kamilwu commented Oct 11, 2019

This is a workaround to an error that occurs when importing apache_beam on macOS 10.15 Catalina.

For more information, refer to a JIRA discussion: https://issues.apache.org/jira/browse/BEAM-8368


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for testing this and writing a fix @kamilwu :)

@@ -119,7 +119,9 @@ def get_version():
'oauth2client>=2.0.1,<4',
'protobuf>=3.5.0.post1,<4',
# [BEAM-6287] pyarrow is not supported on Windows for Python 2
('pyarrow>=0.11.1,<0.15.0; python_version >= "3.0" or '
# [BEAM-8368] pyarrow>=0.14.0 triggers an exception when importing
# apache_beam on macOS 10.15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind filing a jira with arrow and referencing it here? It looks like arrow is considering an 0.15.1 release so maybe this could be resolved there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, jira is filled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilwu
Copy link
Contributor Author

kamilwu commented Oct 14, 2019

Run Python PreCommit

@TheNeuralBit
Copy link
Member

@aaltay should we go ahead and merge this prior to the 2.17.0 cut? We can update it if arrow 0.15.1 is out in time.

@aaltay
Copy link
Member

aaltay commented Oct 14, 2019

@aaltay should we go ahead and merge this prior to the 2.17.0 cut? We can update it if arrow 0.15.1 is out in time.

Yes, thank you. Is arrow 0.15.1 fixing this issue?

@aaltay aaltay merged commit 246cc8d into apache:master Oct 14, 2019
@TheNeuralBit
Copy link
Member

Yeah the fix for ARROW-6860 should be in 0.15.1, and it sounds like that will resolve our issue.

@aaltay
Copy link
Member

aaltay commented Oct 15, 2019

Great, thank you!

@kamilwu kamilwu deleted the pyarrow-downgrade branch October 15, 2019 07:49
@kamilwu
Copy link
Contributor Author

kamilwu commented Oct 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants