Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-7926] Update dependencies in Java Katas #9771

Merged
merged 1 commit into from Oct 24, 2019

Conversation

leonardoam
Copy link

Update several Java Katas dependencies.

Specially, upgrade Gradle from 4.8 to 5.0 and fix deprecated declaration.

    Updates:
    
    Gradle: 4.8 -> 5.0 (and fix deprecated build-in task overwritten
    declaration)
    
    org.apache.beam:beam-sdks-java-core: 2.13.0 -> 2.16.0
    org.apache.beam:beam-runners-direct-java: 2.13.0 -> 2.16.0
    com.google.guava:guava: 27.1-jre -> 28.1-jre
    joda-time:joda-time: 2.10.3 -> 2.10.4
    org.slf4j:slf4j-api: 1.7.26 -> 1.7.28
    org.apache.logging.log4j:log4j-slf4j-impl: 2.11.2 -> 2.12.1
    
    org.assertj:assertj-core: 3.12.2 -> 3.13.2
    org.hamcrest:hamcrest-core: 1.3 -> 2.1
    org.hamcrest:hamcrest-library: 1.3 -> 2.1

R: @henryken @reuvenlax


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Updates:

Gradle: 4.8 -> 5.0 (and fix deprecated build-in task overwritten
declaration)

org.apache.beam:beam-sdks-java-core: 2.13.0 -> 2.16.0
org.apache.beam:beam-runners-direct-java: 2.13.0 -> 2.16.0
com.google.guava:guava: 27.1-jre -> 28.1-jre
joda-time:joda-time: 2.10.3 -> 2.10.4
org.slf4j:slf4j-api: 1.7.26 -> 1.7.28
org.apache.logging.log4j:log4j-slf4j-impl: 2.11.2 -> 2.12.1

org.assertj:assertj-core: 3.12.2 -> 3.13.2
org.hamcrest:hamcrest-core: 1.3 -> 2.1
org.hamcrest:hamcrest-library: 1.3 -> 2.1
@pabloem
Copy link
Member

pabloem commented Oct 22, 2019

Hi @leonardoam ! Thanks for the PR. Have to tested that this combination of dependencies works?

@leonardoam
Copy link
Author

HI @pabloem, I've ran tests and nothing broke.
I also took a look at release notes for major changes and nothing seems to be a reason to break.
If you suspect of anything please let me know.

@pabloem
Copy link
Member

pabloem commented Oct 23, 2019

Alright. LGTM. I'll just ping @henryken once more, and merge in a couple days if he doesn't answer.

@henryken
Copy link
Contributor

LGTM. I had a quick test and nothing breaks.

@pabloem pabloem merged commit 9f27a1d into apache:master Oct 24, 2019
@pabloem
Copy link
Member

pabloem commented Oct 24, 2019

Thanks for the review @henryken
and thanks a lot for the PR @leonardoam !

@aaltay
Copy link
Member

aaltay commented Oct 24, 2019

Was there a typo in the JIRA (https://issues.apache.org/jira/browse/BEAM-7926) mentioned in the title? JIRA does not appear to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants