[BEAM-8391] Update type id write methods in AwsModule
#9783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed (in jackson 2.9) to supported ones.
|
retest this please |
|
retest this please |
|
retest this please |
iemejia
approved these changes
Oct 14, 2019
iemejia
added a commit
that referenced
this pull request
Oct 14, 2019
|
Merged, thanks again. I just saw you are a jackson maintainer catching up downstream, makes sense now :). Never mind about the update suggestion if you don't have the time. |
|
@iemejia You are welcome! I could try 2.10 upgrade, time permitting. There shouldn't be much to do but would definitely want full regression test to be run just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So: (polymorphic) type id write methods were refactored in Jackson 2.9, and change here is to use new methods: these will work better with some data formats (xml, avro, for example). Deprecated methods would work fine for json in 2.x, but seems better to update.
R: @iemejia