Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8387] Remove sdk-worker-parallelism option from JobServerDriver #9785

Merged
merged 1 commit into from Oct 14, 2019

Conversation

tweise
Copy link
Contributor

@tweise tweise commented Oct 14, 2019

This option was added when it wasn't possible to specify the worker count as pipeline option, which is no longer the case. The pipeline option has a special value of 0, which means that the runner should pick a suitable value. Unfortunately this was overridden in FlinkJobInvoker with 1 (because that's the default in the JobServerDriver config). There is no need to have this option in the job server.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tweise tweise requested review from mxm and ibzib October 14, 2019 16:22
Copy link
Contributor

@mxm mxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I agree that the option is not needed in the JobServerDriver..

@ibzib
Copy link
Contributor

ibzib commented Oct 14, 2019

LGTM, I always thought having the same argument set in both places added unnecessary complexity (like BEAM-7657).

@tweise tweise merged commit 6ab60dc into apache:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants