Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-8424] Prevent Java 11 VR tests from timeouting #9819

Merged
merged 2 commits into from Oct 17, 2019
Merged

[BEAM-8424] Prevent Java 11 VR tests from timeouting #9819

merged 2 commits into from Oct 17, 2019

Conversation

lgajowy
Copy link
Contributor

@lgajowy lgajowy commented Oct 17, 2019

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status		 Build Status
Build Status		 --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status		 Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lgajowy
[BEAM-8424] Lower the timeout value for Dataflow ValidatesRunner tests
55b8b0a 
I checked that those tests never exceed 4h 30m limit. It's best to keep
it low - this will force us to investigate when something goes off the
charts.
@lgajowy
[BEAM-8424] Set timeout value of java 11 dataflow validates runner te…
82b3e39 
…sts equal to java 8 equivalents

Testing performance should not differ (or be) worse than on Java 8.
Therefore the timeout value should be equal to java 8 equivalent jobs.
@lgajowy
Copy link
Contributor Author

lgajowy commented Oct 17, 2019

R: @Ardagan , @boyuanzz

Could you take a look? I am changing the timeout values of all dataflow VR tests and keeping them equal for Java11 equivalents (that wasn't the case).

I'm also not sure if this is ok that the tests sometimes take more than 4 hours. Typically they take about 3h - 3h 30min. I imagine that this might be cumbersome for devs to wait that long but maybe this is the only way... Do you think we should mitigate this somehow?

@lgajowy
Copy link
Contributor Author

lgajowy commented Oct 17, 2019

Run seed job

@boyuanzz
Copy link
Contributor

R: @Ardagan , @boyuanzz

Could you take a look? I am changing the timeout values of all dataflow VR tests and keeping them equal for Java11 equivalents (that wasn't the case).

I'm also not sure if this is ok that the tests sometimes take more than 4 hours. Typically they take about 3h - 3h 30min. I imagine that this might be cumbersome for devs to wait that long but maybe this is the only way... Do you think we should mitigate this somehow?

Thanks for handling that! From my understanding, it should be okay for a PostCommit test running that long. We can merge it first to prevent timeout issue. For further work, we could discuss more on whether we want to split this test target in order to decrease test time.

boyuanzz
boyuanzz approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@boyuanzz boyuanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@boyuanzz boyuanzz merged commit d9add56 into apache:master Oct 17, 2019
@lgajowy
Copy link
Contributor Author

lgajowy commented Oct 18, 2019

Sounds good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyuanzz boyuanzz boyuanzz approved these changes

@Ardagan Ardagan Awaiting requested review from Ardagan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lgajowy @boyuanzz