[BEAM-8446] Adding a test checking the wait for BQ jobs #9858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests seem to be failing because of some unrelated reason. |
|
Run Python PreCommit |
Ardagan
approved these changes
Oct 24, 2019
|
Run Python PreCommit |
ttanay
reviewed
Oct 24, 2019
| @@ -424,6 +424,87 @@ def test_records_traverse_transform_with_mocks(self): | |||
| assert_that(jobs, | |||
| equal_to([job_reference]), label='CheckJobs') | |||
|
|
|||
| @mock.patch('time.sleep') | |||
| def test_wait_for_job_completion(self, sleep_mock): | |||
| logging.getLogger().setLevel(logging.INFO) | |||
There was a problem hiding this comment.
Reducing log level to INFO outputs unneccesary stuff like:
INFO:root:==================== <function fix_side_input_pcoll_coders at 0x7fbbfb2d3730> ====================
INFO:root:==================== <function lift_combiners at 0x7fbbfb2d37b8> ====================
INFO:root:==================== <function expand_sdf at 0x7fbbfb2d3840> ====================
INFO:root:==================== <function expand_gbk at 0x7fbbfb2d38c8> ====================
INFO:root:==================== <function sink_flattens at 0x7fbbfb2d39d8> ====================
INFO:root:==================== <function greedily_fuse at 0x7fbbfb2d3a60> ====================
INFO:root:==================== <function read_to_impulse at 0x7fbbfb2d3ae8> ====================
INFO:root:==================== <function impulse_to_input at 0x7fbbfb2d3b70> ====================
INFO:root:==================== <function inject_timer_pcollections at 0x7fbbfb2d3d08> ====================
INFO:root:==================== <function sort_stages at 0x7fbbfb2d3d90> ====================
INFO:root:==================== <function window_pcollection_coders at 0x7fbbfb2d3e18> ====================
INFO:root:Creating state cache with size 100
INFO:root:Created Worker handler <apache_beam.runners.portability.fn_api_runner.EmbeddedWorkerHandler object at 0x7fbbfb2927b8> for environment urn: "beam:env:embedded_python:v1"
INFO:root:Running (((ref_AppliedPTransform_assert_that/Create/Read_9)+(ref_AppliedPTransform_assert_that/Group/pair_with_0_13))+(assert_that/Group/Flatten/Transcode/0))+(assert_that/Group/Flatten/Write/0)
INFO:root:Running (ref_AppliedPTransform_job_ref/Read_3)+(ref_PCollection_PCollection_1/Write)
INFO:root:Running ((((((ref_AppliedPTransform_Create/Read_5)+(ref_AppliedPTransform_ParDo(WaitForBQJobs)_6))+(ref_AppliedPTransform_assert_that/WindowInto(WindowIntoFn)_10))+(ref_AppliedPTransform_assert_that/ToVoidKey_11))+(ref_AppliedPTransform_assert_that/Group/pair_with_1_14))+(assert_that/Group/Flatten/Transcode/1))+(assert_that/Group/Flatten/Write/1)
INFO:root:Job status: <Mock name='mock.status' id='140445338423704'>
INFO:root:Job status: <Mock name='mock.status' id='140445338424376'>
INFO:root:Job status: <Mock name='mock.status' id='140445338424992'>
INFO:root:Running (assert_that/Group/Flatten/Read)+(assert_that/Group/GroupByKey/Write)
INFO:root:Running (((assert_that/Group/GroupByKey/Read)+(ref_AppliedPTransform_assert_that/Group/Map(_merge_tagged_vals_under_key)_20))+(ref_AppliedPTransform_assert_that/Unkey_21))+(ref_AppliedPTransform_assert_that/Match_22)
Can this be removed if it's not being used in the test?
There was a problem hiding this comment.
great catch. thanks tanay!
ttanay
reviewed
Oct 24, 2019
| job_2_done.status.state = 'DONE' | ||
| job_2_done.status.errorResult = None | ||
|
|
||
| job_1_done = mock.Mock() |
There was a problem hiding this comment.
nit: Is job_1_error or something more appropriate, since the job errored out, but the status is DONE?
Can be confused with job_2_done which actually succeeds.
|
Run Python PreCommit |
|
Run Portable_Python PreCommit |
|
Run Python PreCommit |
|
LGTM! Thanks Pablo! |
|
the new tests seem to be failing in py 2.7 - I suspect due to pickling issues. I think I'll skip them on py2.7 |
Ardagan
reviewed
Oct 25, 2019
| job_2_done.status.errorResult = None | ||
|
|
||
| job_1_error = mock.Mock() | ||
| job_1_error.status.state = 'DONE' |
There was a problem hiding this comment.
Does error still returns 'DONE' as state?
There was a problem hiding this comment.
yes, it returns DONE with an error report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test for the logic addedin PR #9856.
r: @ttanay
cc: @Ardagan
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.