Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8368] [BEAM-8392] Update pyarrow to the latest version #9970

Merged
merged 5 commits into from
Nov 4, 2019

Conversation

aaltay
Copy link
Member

@aaltay aaltay commented Nov 1, 2019

Update pyarrow to the latest version.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aaltay aaltay requested a review from Ardagan November 1, 2019 19:28
@aaltay
Copy link
Member Author

aaltay commented Nov 1, 2019

R: @TheNeuralBit

@TheNeuralBit
Copy link
Member

Looks like maybe there was an API change in pyarrow.parquet. I'll take a look

@TheNeuralBit
Copy link
Member

Well it's a pretty simple fix, just need to change this line to pa.Table.from_arrays([orig.column('name')], names=['name'])

@TheNeuralBit
Copy link
Member

Wrote a commit for this and put up a PR to merge into this branch

@aaltay
Copy link
Member Author

aaltay commented Nov 1, 2019

Thank you @TheNeuralBit!

@aaltay
Copy link
Member Author

aaltay commented Nov 2, 2019

Well it's a pretty simple fix, just need to change this line to pa.Table.from_arrays([orig.column('name')], names=['name'])

A bit of a side question. It seems like minor versions could be breaking with pyarrow. Should we pin this library, instead of using an upper bound?

@aaltay
Copy link
Member Author

aaltay commented Nov 4, 2019

Run Python PreCommit

1 similar comment
@aaltay
Copy link
Member Author

aaltay commented Nov 4, 2019

Run Python PreCommit

@aaltay aaltay merged commit 9ed9dc7 into master Nov 4, 2019
@aaltay aaltay deleted the aaltay-patch-1 branch November 4, 2019 22:41
aaltay added a commit to aaltay/beam that referenced this pull request Nov 4, 2019
…pache#9970)

[BEAM-8368] [BEAM-8392] Update pyarrow to the latest version 0.15.1 (apache#9970)
@TheNeuralBit
Copy link
Member

A bit of a side question. It seems like minor versions could be breaking with pyarrow. Should we pin this library, instead of using an upper bound?

They're not supposed to be breaking, in this case I think the breaking change came from 0.14 to 0.15, rather than 0.15.0 to 0.15.1.

Ardagan added a commit that referenced this pull request Nov 12, 2019
Cherry pick: 
Merge pull request #9970: [BEAM-8368] [BEAM-8392] Update pyarrow to the latest version 0.15.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants