Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-3845: Add the command to create the /usr/bigtop folder in the bigtop-select rpm package #1035

Merged
merged 1 commit into from Oct 13, 2022

Conversation

timyuer
Copy link
Contributor

@timyuer timyuer commented Oct 13, 2022

BIGTOP-3845: Add the command to create the /usr/bigtop folder in the bigtop-select rpm package

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
  • Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@kevinw66
Copy link
Contributor

+1 LGTM, tested with prefixed version of Zookeeper and Kafka

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @timyuer and @kevinw66.

@iwasakims iwasakims merged commit 7954fe0 into apache:master Oct 13, 2022
@sekikn
Copy link
Contributor

sekikn commented Oct 13, 2022

@timyuer @kevinw66 Thanks for the contribution! Just a question, STACK_ROOT_DIR is a constant in this PR, but is it still valid if setting another value for the parentDir option instead of /usr/bigtop? e.g., ./gradlew allclean pkgs -Dbuildwithdeps=true -PparentDir=/usr/local/bigtop

@kevinw66
Copy link
Contributor

@timyuer @kevinw66 Thanks for the contribution! Just a question, STACK_ROOT_DIR is a constant in this PR, but is it still valid if setting another value for the parentDir option instead of /usr/bigtop? e.g., ./gradlew allclean pkgs -Dbuildwithdeps=true -PparentDir=/usr/local/bigtop

Hi @sekikn , thanks for your reminder, but we have one more question here, currently the version info in parentDir need to be added explicitly like -PparentDir=/usr/bigtop/3.2.0, should we change the behavior to read from bigtop version and remove -SNAPSHOT automatically?

@sekikn
Copy link
Contributor

sekikn commented Oct 14, 2022

should we change the behavior to read from bigtop version and remove -SNAPSHOT automatically?

@kevinw66 I think that's OK since it doesn't affect the default (without the parentDir option) behavior at all.

@kevinw66
Copy link
Contributor

should we change the behavior to read from bigtop version and remove -SNAPSHOT automatically?

@kevinw66 I think that's OK since it doesn't affect the default (without the parentDir option) behavior at all.

Automatically add version info might be convenience if we wants to use bigtop-select without Ambari in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants