Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-3387: Building QFS fails on CentOS 8 #658

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Conversation

sekikn
Copy link
Contributor

@sekikn sekikn commented Aug 16, 2020

No description provided.

@sekikn
Copy link
Contributor Author

sekikn commented Aug 16, 2020

I confirmed that building qfs succeeded on CentOS 7 (as a regression test), 8 and Fedora 31 with this PR.

@guyuqi
Copy link
Member

guyuqi commented Aug 18, 2020

The build command:
docker run --rm -v pwd:/ws --workdir /ws bigtop/slaves:trunk-centos-8 bash -c '. /etc/profile.d/bigtop.sh; qfs-pkg yum'

It seems to encounter a dependencies issue of net-tools .

> Task :qfs-rpm FAILED
Installing /ws/output/qfs/qfs-2.0.0-1.el8.src.rpm
error: Failed build dependencies:
        net-tools is needed by qfs-2.0.0-1.el8.x86_64

FAILURE: Build failed with an exception.

@sekikn
Copy link
Contributor Author

sekikn commented Aug 22, 2020

@guyuqi Thanks! I missed that because I tested with a VM on which net-tools was already installed.

@sekikn
Copy link
Contributor Author

sekikn commented Aug 22, 2020

Updated the PR. I confirmed this version worked with the docker image, as follows:

$ cd docker/bigtop-slaves
$ ./build.sh trunk-centos-8

(snip)

BUILD SUCCESSFUL in 1m 1s
1 actionable task: 1 executed
Removing intermediate container 178174f487bc
 ---> 4de878edc397
Successfully built 4de878edc397
Successfully tagged bigtop/slaves:trunk-centos-8
++ rm -f Dockerfile
$ cd -
$ docker run --rm -v $(pwd):/ws --workdir /ws bigtop/slaves:trunk-centos-8 bash -c '. /etc/profile.d/bigtop.sh; ./gradlew qfs-clean qfs-pkg yum'

(snip)

> Task :qfs-pkg

> Task :yum
Directory walk started
Directory walk done - 18 packages
Temporary output repo path: /ws/output/.repodata/
Preparing sqlite DBs
Pool started (with 5 workers)
Pool finished

BUILD SUCCESSFUL in 20m 1s
8 actionable tasks: 8 executed

@sekikn sekikn merged commit 380041a into apache:master Aug 25, 2020
@sekikn
Copy link
Contributor Author

sekikn commented Aug 25, 2020

Merged into master. Thanks for the review @guyuqi!

@sekikn sekikn deleted the BIGTOP-3387 branch August 25, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants