New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-2254. Replace the Docker orchestration tool from Vagrant to Do… #74

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@evans-ye
Contributor

evans-ye commented Jan 23, 2016

No description provided.

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 23, 2016

So, you're just moving the provisioner one level up? That's the whole change?

c0s commented on 23f56d0 Jan 23, 2016

So, you're just moving the provisioner one level up? That's the whole change?

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 23, 2016

No, looks like you have also added the work with compose now. Keep on reading.
Do you still think it would be a good idea to commit to the branch, or you're ok with going to the master directly?

c0s replied Jan 23, 2016

No, looks like you have also added the work with compose now. Keep on reading.
Do you still think it would be a good idea to commit to the branch, or you're ok with going to the master directly?

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 23, 2016

I am somewhat confused. Why are you using both vagrant and compose?

c0s replied Jan 23, 2016

I am somewhat confused. Why are you using both vagrant and compose?

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

OK. I've pushed a new commit:
evans-ye@b6579c9

Basically updated the REAME to drop vagrant and switch to docker-compose.
I've also rename the config file name all around the code.

This is for you to review what has been changed.
I'll strip these two into one patch when actually committed.
Thanks!

Contributor

evans-ye commented Jan 24, 2016

OK. I've pushed a new commit:
evans-ye@b6579c9

Basically updated the REAME to drop vagrant and switch to docker-compose.
I've also rename the config file name all around the code.

This is for you to review what has been changed.
I'll strip these two into one patch when actually committed.
Thanks!

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Shall we explicitly mention a requirement for Ubutnu 15 or something? In my tries, setting compose on 14.04 was a complete disaster.

c0s commented on b6579c9 Jan 24, 2016

Shall we explicitly mention a requirement for Ubutnu 15 or something? In my tries, setting compose on 14.04 was a complete disaster.

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

It would be great to document how one can log into these docker containers now when vagrant ssh isn't available anymore.

c0s replied Jan 24, 2016

It would be great to document how one can log into these docker containers now when vagrant ssh isn't available anymore.

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

No. I'll still go to a feature branch so that we don't have confusing things inside 1.1 release.
The feature is completely switched from vagrant to docker-compose. I've removed vagrant name entirely in the new commit. :)

Contributor

evans-ye commented Jan 24, 2016

No. I'll still go to a feature branch so that we don't have confusing things inside 1.1 release.
The feature is completely switched from vagrant to docker-compose. I've removed vagrant name entirely in the new commit. :)

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Contributor

Let's do the branch and keep on working around it. I think your stuff is pretty much ready, but want to play with it a little bit if you don't mind.

Contributor

c0s commented Jan 24, 2016

Let's do the branch and keep on working around it. I think your stuff is pretty much ready, but want to play with it a little bit if you don't mind.

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

How so? It should be just two command:
$ curl -L https://github.com/docker/compose/releases/download/1.5.2/docker-compose-`uname -s-uname -m` > /usr/local/bin/docker-compose
$ chmod +x /usr/local/bin/docker-compose

The docker engine, OTOH, is much complicated on ubuntu 14...

Contributor

evans-ye commented Jan 24, 2016

How so? It should be just two command:
$ curl -L https://github.com/docker/compose/releases/download/1.5.2/docker-compose-`uname -s-uname -m` > /usr/local/bin/docker-compose
$ chmod +x /usr/local/bin/docker-compose

The docker engine, OTOH, is much complicated on ubuntu 14...

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Contributor

Dunno, I've tried it about a month ago - it was a complete mess. I will try again today or tomorrow and comment here. Thanks!

Contributor

c0s commented Jan 24, 2016

Dunno, I've tried it about a month ago - it was a complete mess. I will try again today or tomorrow and comment here. Thanks!

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

I just tried. It should work instantly :)

Contributor

evans-ye commented Jan 24, 2016

I just tried. It should work instantly :)

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

I'll check in to a branch and iterate on it. That way I can also setup a CI for it. Thanks for the review!

Contributor

evans-ye commented Jan 24, 2016

I'll check in to a branch and iterate on it. That way I can also setup a CI for it. Thanks for the review!

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Contributor

Cool, and I will use of the branch to test in my environment. Thanks!

Contributor

c0s commented Jan 24, 2016

Cool, and I will use of the branch to test in my environment. Thanks!

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Contributor

Yeah, looks like I know what my problem with the installation was. I've tried to do 'pip install' which was an idiotic idea, cause nothing really works in Python world out of the box. the way you suggested it, indeed, worked well. Thanks!

Contributor

c0s commented Jan 24, 2016

Yeah, looks like I know what my problem with the installation was. I've tried to do 'pip install' which was an idiotic idea, cause nothing really works in Python world out of the box. the way you suggested it, indeed, worked well. Thanks!

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

Awesome! Glad it works!

Contributor

evans-ye commented Jan 24, 2016

Awesome! Glad it works!

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Contributor

One more though: perhaps, it makes sense to add a version of README to the new provisioner directory? It is a bit awkward to read about compose in the README belonging to vagrant provisioner. No?

Contributor

c0s commented Jan 24, 2016

One more though: perhaps, it makes sense to add a version of README to the new provisioner directory? It is a bit awkward to read about compose in the README belonging to vagrant provisioner. No?

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

I'm not quite sure what you mean by:
It is a bit awkward to read about compose in the README belonging to vagrant provisioner. No?

Right now we have bigtop/provisioner/docker/README.md for docker-compose.
There will be bigtop/provisioner/vagrant/REAME.md for vagrant provisioner onece we moved it from bigotp-deploy.

Contributor

evans-ye commented Jan 24, 2016

I'm not quite sure what you mean by:
It is a bit awkward to read about compose in the README belonging to vagrant provisioner. No?

Right now we have bigtop/provisioner/docker/README.md for docker-compose.
There will be bigtop/provisioner/vagrant/REAME.md for vagrant provisioner onece we moved it from bigotp-deploy.

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Contributor

I don't see bigtop/provisioner/docker/README.md file at all. Looks like that changes to README were made to bigtop-deploy/vm/vagrant-provisioner-docker/REAME.md
Sorry if I am confusing something, but the first location doesn't seem to have any readme files.

Contributor

c0s commented Jan 24, 2016

I don't see bigtop/provisioner/docker/README.md file at all. Looks like that changes to README were made to bigtop-deploy/vm/vagrant-provisioner-docker/REAME.md
Sorry if I am confusing something, but the first location doesn't seem to have any readme files.

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

It's in the right place:
https://github.com/apache/bigtop/blob/BIGTOP-2253/provisioner/docker/README.md
Would you mind to check again?

Contributor

evans-ye commented Jan 24, 2016

It's in the right place:
https://github.com/apache/bigtop/blob/BIGTOP-2253/provisioner/docker/README.md
Would you mind to check again?

@c0s

This comment has been minimized.

Show comment
Hide comment
@c0s

c0s Jan 24, 2016

Contributor

Sorry, you're right. Getting tired...
Do you think we need to provide a mechanism for ppl to get into these containers via ssh or 'docker attach' or else? Thanks!

Contributor

c0s commented Jan 24, 2016

Sorry, you're right. Getting tired...
Do you think we need to provide a mechanism for ppl to get into these containers via ssh or 'docker attach' or else? Thanks!

@evans-ye

This comment has been minimized.

Show comment
Hide comment
@evans-ye

evans-ye Jan 24, 2016

Contributor

Sure. That what I plan to do in BIGTOP-2273.

Contributor

evans-ye commented Jan 24, 2016

Sure. That what I plan to do in BIGTOP-2273.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment