Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-2254. Replace the Docker orchestration tool from Vagrant to Do… #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

evans-ye
Copy link
Contributor

No description provided.

@evans-ye
Copy link
Contributor Author

OK. I've pushed a new commit:
evans-ye@b6579c9

Basically updated the REAME to drop vagrant and switch to docker-compose.
I've also rename the config file name all around the code.

This is for you to review what has been changed.
I'll strip these two into one patch when actually committed.
Thanks!

@evans-ye
Copy link
Contributor Author

No. I'll still go to a feature branch so that we don't have confusing things inside 1.1 release.
The feature is completely switched from vagrant to docker-compose. I've removed vagrant name entirely in the new commit. :)

@ghost
Copy link

ghost commented Jan 24, 2016

Let's do the branch and keep on working around it. I think your stuff is pretty much ready, but want to play with it a little bit if you don't mind.

@evans-ye
Copy link
Contributor Author

How so? It should be just two command:
$ curl -L https://github.com/docker/compose/releases/download/1.5.2/docker-compose-`uname -s-uname -m` > /usr/local/bin/docker-compose
$ chmod +x /usr/local/bin/docker-compose

The docker engine, OTOH, is much complicated on ubuntu 14...

@ghost
Copy link

ghost commented Jan 24, 2016

Dunno, I've tried it about a month ago - it was a complete mess. I will try again today or tomorrow and comment here. Thanks!

@evans-ye
Copy link
Contributor Author

I just tried. It should work instantly :)

@evans-ye
Copy link
Contributor Author

I'll check in to a branch and iterate on it. That way I can also setup a CI for it. Thanks for the review!

@ghost
Copy link

ghost commented Jan 24, 2016

Cool, and I will use of the branch to test in my environment. Thanks!

@ghost
Copy link

ghost commented Jan 24, 2016

Yeah, looks like I know what my problem with the installation was. I've tried to do 'pip install' which was an idiotic idea, cause nothing really works in Python world out of the box. the way you suggested it, indeed, worked well. Thanks!

@evans-ye
Copy link
Contributor Author

Awesome! Glad it works!

@ghost
Copy link

ghost commented Jan 24, 2016

One more though: perhaps, it makes sense to add a version of README to the new provisioner directory? It is a bit awkward to read about compose in the README belonging to vagrant provisioner. No?

@evans-ye
Copy link
Contributor Author

I'm not quite sure what you mean by:
It is a bit awkward to read about compose in the README belonging to vagrant provisioner. No?

Right now we have bigtop/provisioner/docker/README.md for docker-compose.
There will be bigtop/provisioner/vagrant/REAME.md for vagrant provisioner onece we moved it from bigotp-deploy.

@ghost
Copy link

ghost commented Jan 24, 2016

I don't see bigtop/provisioner/docker/README.md file at all. Looks like that changes to README were made to bigtop-deploy/vm/vagrant-provisioner-docker/REAME.md
Sorry if I am confusing something, but the first location doesn't seem to have any readme files.

@evans-ye
Copy link
Contributor Author

It's in the right place:
https://github.com/apache/bigtop/blob/BIGTOP-2253/provisioner/docker/README.md
Would you mind to check again?

@ghost
Copy link

ghost commented Jan 24, 2016

Sorry, you're right. Getting tired...
Do you think we need to provide a mechanism for ppl to get into these containers via ssh or 'docker attach' or else? Thanks!

@evans-ye
Copy link
Contributor Author

Sure. That what I plan to do in BIGTOP-2273.

1328449337 added a commit to 1328449337/bigtop that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant