New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIGTOP-2254. Replace the Docker orchestration tool from Vagrant to Do… #74
base: master
Are you sure you want to change the base?
Conversation
OK. I've pushed a new commit: Basically updated the REAME to drop vagrant and switch to docker-compose. This is for you to review what has been changed. |
No. I'll still go to a feature branch so that we don't have confusing things inside 1.1 release. |
Let's do the branch and keep on working around it. I think your stuff is pretty much ready, but want to play with it a little bit if you don't mind. |
How so? It should be just two command: The docker engine, OTOH, is much complicated on ubuntu 14... |
Dunno, I've tried it about a month ago - it was a complete mess. I will try again today or tomorrow and comment here. Thanks! |
I just tried. It should work instantly :) |
I'll check in to a branch and iterate on it. That way I can also setup a CI for it. Thanks for the review! |
Cool, and I will use of the branch to test in my environment. Thanks! |
Yeah, looks like I know what my problem with the installation was. I've tried to do 'pip install' which was an idiotic idea, cause nothing really works in Python world out of the box. the way you suggested it, indeed, worked well. Thanks! |
Awesome! Glad it works! |
One more though: perhaps, it makes sense to add a version of README to the new provisioner directory? It is a bit awkward to read about compose in the README belonging to vagrant provisioner. No? |
I'm not quite sure what you mean by: Right now we have bigtop/provisioner/docker/README.md for docker-compose. |
I don't see bigtop/provisioner/docker/README.md file at all. Looks like that changes to README were made to bigtop-deploy/vm/vagrant-provisioner-docker/REAME.md |
It's in the right place: |
Sorry, you're right. Getting tired... |
Sure. That what I plan to do in BIGTOP-2273. |
[Fixed] apache#74,apache#302,apache#335,apache#356 更新github镜像地址
No description provided.