BIGTOP-3558. Fix build failure of HBase on ppc64le. #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iwasakims great job, but please check my comment in https://issues.apache.org/jira/browse/BIGTOP-3558 |
|
@iwasakims Would you add the following change to do-component-build? I tested the PR on the ppc64le worker node, but the default version of asciidoctorj seems to cause OOM when generating PDF. |
…y by avoiding duplicate architecture specific conditionals.
|
@afsanjar Thanks. The patch you mentioned ( https://github.com/ppc64le/build-scripts/blob/master/p/protoc/ubuntu-20.04/protoc-3.5.1.patch ) looks like backport of protocolbuffers/protobuf@36ba04b . I'm going to add the patch to bigtop_toolchain. |
|
+1 |
|
I'm also +1, tested on the ppc64le worker node that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/BIGTOP-3558
ppc64le binary of protoc 3.5.1-1 is not available in maven repositories. Creating artifact from locally installed protobuf-3.5.1.1 should be fix. same as done on #785 and #786 .
I did not test this on my local since I don't have ppc64le environment now.
The same fix with replacement of
s/ppc64le/aarch64/gworked on CentOS 7 aarch64.