Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-3709. Bring protobuf 2.5.0 back for building HBase on aarch64 and ppc64le. #920

Merged
merged 1 commit into from Jun 29, 2022

Conversation

iwasakims
Copy link
Member

https://issues.apache.org/jira/browse/BIGTOP-3709

We still need locally installed protobuf-2.5.0 removed by BIGTOP-3438(#915) for building HBase on aarch64 and ppc64le.

I used /usr/local/protobuf-2.5.0 as new destination since /usr/local is the prefix of protobuf-3.7.1 now.

@iwasakims
Copy link
Member Author

testing this on CentOS 7 aarch64. While the issue caused by protobuf was fixed, got another error on hbase-assembly.

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (check-aggregate-license) @ hbase-assembly ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.EvaluateBeanshell failed with message:
License errors detected, for more detail find ERROR in
                    /home/centos/srcs/bigtop/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE

@iwasakims
Copy link
Member Author

The cause seems to be leveldbjni-all bundled with Hadoop by Bigtop.

$ grep -B 2 'ERROR:' /home/centos/srcs/bigtop/build/hbase/rpm/BUILD/hbase-2.4.11/hbase-assembly/target/maven-shared-archive-resources/META-INF/LICENSE
This product includes leveldbjni-all licensed under the The BSD 3-Clause License.

ERROR: Please check ^^^^^^^^^^^^ this License for acceptability here:

@iwasakims
Copy link
Member Author

I would like to merge this PR first then address license issue in follow-up. filed BIGTOP-3710.

@iwasakims
Copy link
Member Author

The error in check-aggregate-license of hbase-assembly should be fixed by #921.

@guyuqi
Copy link
Member

guyuqi commented Jun 29, 2022

+1 LGTM

@guyuqi guyuqi merged commit 3020ab5 into apache:master Jun 29, 2022
@guyuqi
Copy link
Member

guyuqi commented Jun 29, 2022

Thanks, @iwasakims

sekikn pushed a commit to sekikn/bigtop that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants