BIGTOP-3763: Fix Hive build issues about protobuf 2.5.0 on Arm64 and PPC64le #970
Conversation
…PPC64le 1.Fix Hive build issues about protobuf 2.5.0 on Arm64 and PPC64le when upgrading hadoop to 3.3.3/3.3.4, 2.Expand Java heap size. Change-Id: Iea3fb2bc110210b990031fb13b3ec3aeb4c83109 Signed-off-by: Yuqi Gu <yuqi.gu@arm.com>
|
Tested it on Arm64 rockylinux8: |
| fi | ||
| export MAVEN_OPTS="${MAVEN_OPTS} -Xmx1500m -Xms1500m" | ||
| export MAVEN_OPTS="${MAVEN_OPTS} -Xmx2500m -Xms2500m" |
There was a problem hiding this comment.
How about removing -Xms1500m to make JVM allocate heap on demand? We can not expect much gain by allocating maximum heap from the beginning for short term task like building products. I got no OOM with current settings on my x86_64 environment.
There was a problem hiding this comment.
It makes sense.
Removed this setting and also tested it on my Arm64 environment.
There was a problem hiding this comment.
While -Xmx2500m might be still useful to allocate enough heap on machine with memory less than 5GB (because the default maximum heap of JVM is capped at half of the machine's memory IIRC), we can not practically use such a small machine for Bigtop development. I think dropping -Xmx too should be ok.
Change-Id: I59811ca32e70a8a2c8eb261e55b0e8470590b7ce Signed-off-by: Yuqi Gu <yuqi.gu@arm.com>
There was a problem hiding this comment.
LGTM. tested on CentOS 7 aarch64 .
While I got the error I commented to BIGTOP-3760, applying the patch of #964 fixed the issue.
Description of PR
1.Fix Hive build issues about protobuf 2.5.0 on Arm64 and
PPC64le when upgrading hadoop to 3.3.3/3.3.4,
2.Expand Java heap size.
How was this patch tested?
For code changes:
Build Hive and run smoke tests