Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP-25: Refactor checksum implementation: move it to protocol module #1007

Closed
ArvinDevel opened this issue Jan 18, 2018 · 0 comments
Closed

BP-25: Refactor checksum implementation: move it to protocol module #1007

ArvinDevel opened this issue Jan 18, 2018 · 0 comments
Assignees
@ArvinDevel
Labels
area/client area/protocol BP release/4.7.0 type/task
Milestone
4.7.0

Comments

@ArvinDevel
Copy link
Contributor

ArvinDevel commented Jan 18, 2018 •
edited by sijie
Loading

BP

This is the master ticket for tracking BP-25:

Checksum semantic is more close to wire protocol compared to client, so refactor checksum implementation by moving it to protocol module

Proposal PR - #1008
@ArvinDevel ArvinDevel mentioned this issue Jan 18, 2018
Closed
sijie pushed a commit that referenced this issue Jan 24, 2018
@ArvinDevel @sijie
BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper
a512b73 
Descriptions of the changes in this PR:

Current the checksum implementation is in client module while the checksum semantic is more close to protocol. Moreover, moving the checksum implementation to protocol will avoid server module's dependency to client module when doing checksum in server side.

Master Issue: #1007

Author: Arvin <arvindevel@gmail.com>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>, Venkateswararao Jujjuri <vjujjuri@salesforce.com>

This closes #1008 from ArvinDevel/BP_25_MovingChecksumToProto
@sijie sijie added this to the 4.7.0 milestone Jan 24, 2018
@sijie sijie closed this as completed in a764c7f Jan 24, 2018
@sijie sijie added the BP label Jan 24, 2018
@sijie sijie changed the title Refactor checksum implementation: move it to protocol module BP-25: Refactor checksum implementation: move it to protocol module Jan 24, 2018
sijie added a commit to sijie/bookkeeper that referenced this issue Jan 24, 2018
@sijie
Mark BP-20/BP-25 as adopted
156d003 
This closes apache#1007
@sijie sijie mentioned this issue Jan 24, 2018
Closed
sijie added a commit that referenced this issue Jan 25, 2018
@sijie
Mark BP-20/BP-25 as adopted
4a4276f 
Descriptions of the changes in this PR:

BP-20 is adopted in #760  #761
BP-25 is adopted in #1007 #1008

This closes #760 #761 #1007 #1008

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes #1047 from sijie/close_bp_25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArvinDevel ArvinDevel

Labels
area/client area/protocol BP release/4.7.0 type/task
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
2 participants
@sijie @ArvinDevel