Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookie disk monitor should also monitor journal disks #1349

Open
sijie opened this issue Apr 17, 2018 · 0 comments
Open

Bookie disk monitor should also monitor journal disks #1349

sijie opened this issue Apr 17, 2018 · 0 comments

Comments

@sijie
Copy link
Member

sijie commented Apr 17, 2018

FEATURE REQUEST

  1. Please describe the feature you are requesting.

currently we monitor ledger and index directories. we should also monitor journal directories and turn bookies into readonly when journal disks are full.

  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

should-have

  1. Provide any additional detail on your proposed use case for this feature.

a simple approach is just adding another ledger dirs manager/monitor to monitor journal directories. However this approach might not work well, because there will be 2-3 ledger listeners on reacting to different disks. they are acting independently so there will be a lot of race conditions on handling state transition.

a better approach is to refactor the ledger dirs manager and monitor to have one manager and monitor react to state transaction.

@sijie sijie added this to the 4.8.0 milestone Apr 17, 2018
@eolivelli eolivelli modified the milestones: 4.8.0, 4.9.0 Sep 6, 2018
@sijie sijie modified the milestones: 4.9.0, 4.10.0 Dec 27, 2018
@jiazhai jiazhai modified the milestones: 4.10.0, 4.11.0 Oct 29, 2019
@rdhabalia rdhabalia modified the milestones: 4.11.0, 4.12.0 Jun 18, 2020
@eolivelli eolivelli modified the milestones: 4.12.0, 4.13.0 Nov 4, 2020
@dlg99 dlg99 modified the milestones: 4.13.0, 4.14.0 Feb 16, 2021
@dlg99 dlg99 modified the milestones: 4.14.0, 4.15.0 May 7, 2021
@dlg99 dlg99 modified the milestones: 4.15.0, 4.16.0 Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants