Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensemble change on Delayed Write Failure #1390

Closed
jvrao opened this issue May 4, 2018 · 0 comments
Closed

Ensemble change on Delayed Write Failure #1390

jvrao opened this issue May 4, 2018 · 0 comments
Assignees
@jvrao
Labels
area/client durability
Milestone
4.8.0

Comments

@jvrao
Copy link
Contributor

jvrao commented May 4, 2018

  1. Please describe the feature you are requesting.
    BK ignores any write failures after meeting ack quorum and successfully responding back to the application.
    We should make the ensemble change on delayed write failures so one bad bookie should not cause extended under replication of many entries.
@jvrao jvrao self-assigned this May 4, 2018
jvrao added a commit to jvrao/bookkeeper that referenced this issue May 5, 2018
@jvrao
ISSUE apache#1390 Ensemble change on delayed write error
8eb6269 
Error on delayed writes are dropped if the addEntry
is in complete state (ack quorum satisfied).
This change records the delayed write failure and forces
ensemble change onthe next write. This saves from having
extended under replicated status on the ledger and also
avoids unnecessary build up at PCBC channel.

Signed-off-by: Venkateswararao Jujjuri (JV) <vjujjuri@salesforce.com>
@sijie sijie closed this as completed in a267478 May 17, 2018
reddycharan pushed a commit to reddycharan/bookkeeper that referenced this issue Jul 24, 2018
@jvrao
(@bug W-5080323@) Ensemble change on delayed write error
5e12add 
ISSUE apache#1390
Error on delayed writes are dropped if the addEntry
is in complete state (ack quorum satisfied).
This change records the delayed write failure and forces
ensemble change onthe next write. This saves from having
extended under replicated status on the ledger and also
avoids unnecessary build up at PCBC channel.

Signed-off-by: Venkateswararao Jujjuri (JV) <vjujjurisalesforce.com>

Descriptions of the changes in this PR:

Author: JV Jujjuri <vjujjuri@salesforce.com>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

(@Rev sjust)
@eolivelli eolivelli added this to the 4.8.0 milestone Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvrao jvrao

Labels
area/client durability
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
2 participants
@jvrao @eolivelli