Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bookkeeper should fallback to use v3 protocol for some types of requests if they are not implemented in v2 #2071

Closed
sijie opened this issue Apr 24, 2019 · 2 comments

Comments

@sijie
Copy link
Member

sijie commented Apr 24, 2019

FEATURE REQUEST

  1. Please describe the feature you are requesting.

Currently not all the features are available in v2 protocol. Such as readLac, writeLac, getBookieInfo. The gap is increasing as well. Moving forward, it is really hard to maintain what features are not available when useV2WireProtocol is used.

When a bookkeeper client is configured with useV2WireProtocol = true, it should fallback to use v3 protocol for the types of request that v2 doesn't support. This would allow use have a fully functional client even when using useV2WireProtocol = true.

  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have).

This is a blocker for apache/pulsar#3828

  1. Provide any additional detail on your proposed use case for this feature.

For addressing the problem in apache/pulsar#3828

@sijie
Copy link
Member Author

sijie commented Apr 24, 2019

/cc @zymap

zymap added a commit to zymap/bookkeeper that referenced this issue May 5, 2019
---

Fixes apache#2071

*Motivation*

A bookkeeper should fallback to use v3 protocol for some types of requests if they are not implemented in v2

*Modifications*

- Add a client pool use v3 wire protocol
- Obtain client by version
zymap added a commit to zymap/bookkeeper that referenced this issue May 5, 2019
---

Fixes apache#2071

*Motivation*

A bookkeeper should fallback to use v3 protocol for some types of requests if they are not implemented in v2

*Modifications*

- Add a client pool use v3 wire protocol
- Obtain client by version
sijie pushed a commit that referenced this issue May 20, 2019
…t implemented in v2

Descriptions of the changes in this PR:

### Motivation

#2071 

### Changes

- Add a client pool use v3 wire protocol
- Obtain client by version
- Currently only support `writeLac` and `readLac`

Master Issue: #2071 

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #2085 from zymap/compatible_protocol
@sijie
Copy link
Member Author

sijie commented Aug 18, 2019

This has been implemented and fixed by #2085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant