Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocksDB occasionally crashes with _ZN7rocksdb6DBImpl11NewIteratorERKNS_11ReadOptionsEPNS_18ColumnFamilyHandleE+0x14f #3024

Closed
dlg99 opened this issue Feb 4, 2022 · 0 comments
Labels

Comments

@dlg99
Copy link
Contributor

dlg99 commented Feb 4, 2022

BUG REPORT

Describe the bug

RocksDB occasionally (?) crashes with _ZN7rocksdb6DBImpl11NewIteratorERKNS_11ReadOptionsEPNS_18ColumnFamilyHandleE+0x14f

I noticed that tests got flakier on CI, tried to repro, tests succeeded on all local runs but I noticed the error log.

To Reproduce

No idea. Ran the tests for the bookkeeper-server, tests do retries.
When I checked later the test run reported success but I noticed the error dump (attached)

Expected behavior

No crash

Additional context

..
# Problematic frame:
# C  [librocksdbjni13858492392843593377.jnilib+0xd8fdf]  _ZN7rocksdb6DBImpl11NewIteratorERKNS_11ReadOptionsEPNS_18ColumnFamilyHandleE+0x14f
..
Current thread (0x00007fc0d1cc0000):  JavaThread "GarbageCollectorThread-328-1" [_thread_in_native, id=58223, stack(0x0000700012b9e000,0x0000700012c9e000)]

Stack: [0x0000700012b9e000,0x0000700012c9e000],  sp=0x0000700012c9d150,  free space=1020k
Native frames: (J=compiled Java code, A=aot compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [librocksdbjni13858492392843593377.jnilib+0xd8fdf]  _ZN7rocksdb6DBImpl11NewIteratorERKNS_11ReadOptionsEPNS_18ColumnFamilyHandleE+0x14f
C  [librocksdbjni13858492392843593377.jnilib+0x2421d]  Java_org_rocksdb_RocksDB_iterator__JJ+0xbd
j  org.rocksdb.RocksDB.iterator(JJ)J+0
j  org.rocksdb.RocksDB.newIterator(Lorg/rocksdb/ReadOptions;)Lorg/rocksdb/RocksIterator;+14
j  org.apache.bookkeeper.bookie.storage.ldb.KeyValueStorageRocksDB.iterator()Lorg/apache/bookkeeper/bookie/storage/ldb/KeyValueStorage$CloseableIterator;+8
j  org.apache.bookkeeper.bookie.storage.ldb.PersistentEntryLogMetadataMap.forEach(Ljava/util/function/BiConsumer;)V+4
j  org.apache.bookkeeper.bookie.GarbageCollectorThread.doGcEntryLogs()V+20
j  org.apache.bookkeeper.bookie.GarbageCollectorThread.runWithFlags(ZZZ)V+35
j  org.apache.bookkeeper.bookie.GarbageCollectorThread.safeRun()V+28
J 5952 c2 org.apache.bookkeeper.common.util.SafeRunnable.run()V (22 bytes) @ 0x000000011fc0ab7c [0x000000011fc0ab40+0x000000000000003c]
J 4184 c1 java.util.concurrent.Executors$RunnableAdapter.call()Ljava/lang/Object; java.base@11.0.11 (14 bytes) @ 0x0000000118c3ccd4 [0x0000000118c3cbc0+0x0000000000000114]
J 5726 c1 java.util.concurrent.FutureTask.runAndReset()Z java.base@11.0.11 (125 bytes) @ 0x00000001190bbb4c [0x00000001190bb480+0x00000000000006cc]
J 4362 c1 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run()V java.base@11.0.11 (57 bytes) @ 0x0000000118cbd824 [0x0000000118cbd640+0x00000000000001e4]
J 4459 c1 java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V java.base@11.0.11 (187 bytes) @ 0x0000000118d06d44 [0x0000000118d05ee0+0x0000000000000e64]
J 5300 c1 java.util.concurrent.ThreadPoolExecutor$Worker.run()V java.base@11.0.11 (9 bytes) @ 0x0000000118fc1fc4 [0x0000000118fc1f40+0x0000000000000084]
J 5042 c1 io.netty.util.concurrent.FastThreadLocalRunnable.run()V (22 bytes) @ 0x0000000118efba6c [0x0000000118efb960+0x000000000000010c]
J 4002 c1 java.lang.Thread.run()V java.base@11.0.11 (17 bytes) @ 0x0000000118bd7184 [0x0000000118bd7040+0x0000000000000144]

See
hs_err_pid87757.log

@dlg99 dlg99 added the type/bug label Feb 4, 2022
@dlg99 dlg99 mentioned this issue Feb 4, 2022
dlg99 added a commit that referenced this issue Feb 9, 2022
Descriptions of the changes in this PR:

Dependency change

### Motivation

I encountered #3024 and noticed that newer version of RocksDB includes multiple fixes for concurrency issues with various side-effects and fixes for a few crashes.
I upgraded, ran `org.apache.bookkeeper.bookie.BookieJournalTest` test in a loop and didn't repro the crash so far.
It is hard to say 100% if it is fixed given it was not happening all the time. 

### Changes

Upgraded RocksDB
Master Issue: #3024



Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Nicolò Boschi <boschi1997@gmail.com>

This closes #3026 from dlg99/rocksdb-upgrade
@dlg99 dlg99 closed this as completed Feb 9, 2022
StevenLuMT pushed a commit to StevenLuMT/bookkeeper that referenced this issue Feb 16, 2022
Descriptions of the changes in this PR:

Dependency change

### Motivation

I encountered apache#3024 and noticed that newer version of RocksDB includes multiple fixes for concurrency issues with various side-effects and fixes for a few crashes.
I upgraded, ran `org.apache.bookkeeper.bookie.BookieJournalTest` test in a loop and didn't repro the crash so far.
It is hard to say 100% if it is fixed given it was not happening all the time. 

### Changes

Upgraded RocksDB
Master Issue: apache#3024



Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Nicolò Boschi <boschi1997@gmail.com>

This closes apache#3026 from dlg99/rocksdb-upgrade
Ghatage pushed a commit to sijie/bookkeeper that referenced this issue Jul 12, 2024
Descriptions of the changes in this PR:

Dependency change

### Motivation

I encountered apache#3024 and noticed that newer version of RocksDB includes multiple fixes for concurrency issues with various side-effects and fixes for a few crashes.
I upgraded, ran `org.apache.bookkeeper.bookie.BookieJournalTest` test in a loop and didn't repro the crash so far.
It is hard to say 100% if it is fixed given it was not happening all the time. 

### Changes

Upgraded RocksDB
Master Issue: apache#3024



Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Nicolò Boschi <boschi1997@gmail.com>

This closes apache#3026 from dlg99/rocksdb-upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant