Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the protobuf syntax to 'proto2' #492

Closed
zhaijack opened this issue Sep 4, 2017 · 0 comments
Closed

Set the protobuf syntax to 'proto2' #492

zhaijack opened this issue Sep 4, 2017 · 0 comments
Assignees
@zhaijack
Labels
area/protocol release/4.6.0 type/task
Milestone
4.6.0

Comments

@zhaijack
Copy link
Contributor

zhaijack commented Sep 4, 2017

FEATURE REQUEST

  1. Please describe the feature you are requesting.

#473 bumped the protobuf version to 3.x. and in #491, we might introduce new metadata rpc based on protobuf3. so it would be great to set explicit proto syntax to proto2 for existing protobuf versions.

  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

nice-to-have

  1. Provide any additional detail on your proposed use case for this feature.

N/A
@sijie sijie added this to the 4.6.0 milestone Sep 6, 2017
@sijie sijie closed this as completed in e48f9d0 Sep 6, 2017
athanatos pushed a commit to athanatos/bookkeeper that referenced this issue Jan 25, 2019
@sel-fish @hanm
ZOOKEEPER-3001: Incorrect log message when try to delete container node
8cfca3a 
Missing `String.format`.

Author: sel-fish <fqlgy@hotmail.com>

Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, Andor Molnár <andor@cloudera.com>, Michael Han <hanm@apache.org>, maoling <maoling199210191@sina.com>

Closes apache#492 from sel-fish/ZOOKEEPER-3001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaijack zhaijack

Labels
area/protocol release/4.6.0 type/task
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
2 participants
@sijie @zhaijack