Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In ReadOnlyLedgerHandle, metadata gets updated in the event of writeclose but lastAddConfirmed and length is not getting updated. #594

Open
ivankelly opened this issue Oct 17, 2017 · 1 comment
Open

In ReadOnlyLedgerHandle, metadata gets updated in the event of writeclose but lastAddConfirmed and length is not getting updated. #594

ivankelly opened this issue Oct 17, 2017 · 1 comment
Labels
jiramigrated triage/week-33 type/bug
Milestone
4.16.0

Comments

@ivankelly
Copy link
Contributor

JIRA: https://issues.apache.org/jira/browse/BOOKKEEPER-929

Reporter: Venkateswararao Jujjuri (JV) @jvrao

In ReadOnlyLedgerHandle, metadata gets updated in the event of writeclose but lastAddConfirmed and length are not getting updated.

Comments from JIRA

Sijie Guo 2017-07-17T21:33:58.543+0000

[~jujjuri] do you guys have any patch for this?

Venkateswararao Jujjuri (JV) 2017-07-18T05:21:39.446+0000

I do; will post it.

Sijie Guo 2017-07-25T00:23:06.620+0000

[~jujjuri] shall we include this in 4.5.0? or shall we move to next release?

Sijie Guo 2017-07-28T00:04:37.257+0000

since it is minor, moves this to 4.6.0
@jiazhai jiazhai added this to the 4.7.0 milestone Nov 4, 2017
@ivankelly
Copy link
Contributor Author

@jvrao ok to bump to 4.8.0?

@sijie sijie modified the milestones: 4.7.0, 4.8.0 Mar 12, 2018
@eolivelli eolivelli modified the milestones: 4.8.0, 4.9.0 Sep 6, 2018
@sijie sijie modified the milestones: 4.9.0, 4.10.0 Dec 27, 2018
@sijie sijie unassigned jvrao Dec 27, 2018
athanatos pushed a commit to athanatos/bookkeeper that referenced this issue Jan 25, 2019
@anmolnar
ZOOKEEPER-3116: Make the DataTree.approximateDataSize more efficient
687ea7e 
Cache the approximate data tree size, and update it when txns applied to data tree, this could make this query not that expensive.

Author: Fangmin Lyu <allenlyu@fb.com>

Reviewers: andor@apache.org

Closes apache#594 from lvfangmin/ZOOKEEPER-3116 and squashes the following commits:

ad2ce216 [Fangmin Lyu] move to synchronize when visiting node.data
2e0cbb17 [Fangmin Lyu] add test case to test cached approximate data tree size
21243f5e [Fangmin Lyu] cache the approximate data size in DataTree
@jiazhai jiazhai modified the milestones: 4.10.0, 4.11.0 Oct 29, 2019
@sijie sijie mentioned this issue Jan 15, 2020
Open
@rdhabalia rdhabalia modified the milestones: 4.11.0, 4.12.0 Jun 18, 2020
@eolivelli eolivelli modified the milestones: 4.12.0, 4.13.0 Nov 4, 2020
@dlg99 dlg99 modified the milestones: 4.13.0, 4.14.0 Feb 16, 2021
@dlg99 dlg99 modified the milestones: 4.14.0, 4.15.0 May 7, 2021
@dlg99 dlg99 modified the milestones: 4.15.0, 4.16.0 Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
jiramigrated triage/week-33 type/bug
Projects
None yet
Milestone
4.16.0
Development

No branches or pull requests
7 participants
@jvrao @ivankelly @sijie @rdhabalia @jiazhai @dlg99 @eolivelli