Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bookie recovery work with recovering multiple bookies #612

Closed
ivankelly opened this issue Oct 17, 2017 · 1 comment
Closed

Make bookie recovery work with recovering multiple bookies #612

ivankelly opened this issue Oct 17, 2017 · 1 comment
Assignees
@sijie
Labels
area/tools release/4.6.0 type/feature
Milestone
4.6.0

Comments

@ivankelly
Copy link
Contributor

JIRA: https://issues.apache.org/jira/browse/BOOKKEEPER-818

Reporter: Sijie Guo @sijie

Make recovery tool work with multiple bookies so we could recover bookies inside ensemble at one time call. so we don't need to run the tool multiple times when we want to recover multiple bookies

Comments from JIRA

Sijie Guo 2017-07-28T00:03:08.816+0000

move replication related changes to 4.6.0
@jiazhai jiazhai added this to the 4.7.0 milestone Nov 4, 2017
@sijie
Copy link
Member

sijie commented Nov 4, 2017

#641 address the core issue. I need to integrate this in the tool. I will do this for 4.6.0.

@sijie sijie modified the milestones: 4.7.0, 4.6.0 Nov 4, 2017
@jiazhai jiazhai modified the milestones: 4.6.0, 4.7.0 Nov 12, 2017
jiazhai pushed a commit that referenced this issue Nov 12, 2017
@sijie @jiazhai
ISSUE #612: Make bookie recovery work with recovering multiple bookies
966244d 
Descriptions of the changes in this PR:

This is a change ported from twitter branch.

- Enable recovering multiple bookies in bookie shell
- Add a unit test for BookieShell.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes #714 from sijie/recover_command_fix, closes #612

(cherry picked from commit dad7e2c)
Signed-off-by: Jia Zhai <zhaijia@apache.org>
@sijie sijie mentioned this issue Nov 13, 2017
Closed
@sijie sijie modified the milestones: 4.7.0, 4.6.0 Nov 22, 2017
philipsu522 pushed a commit to philipsu522/bookkeeper that referenced this issue Dec 8, 2017
@sijie
ISSUE apache#612: Make bookie recovery work with recovering multiple …
0eaabf2 
…bookies

Descriptions of the changes in this PR:

This is a change ported from twitter branch.

- Enable recovering multiple bookies in bookie shell
- Add a unit test for BookieShell.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes apache#714 from sijie/recover_command_fix, closes apache#612
aojea pushed a commit to aojea/bookkeeper that referenced this issue Dec 16, 2017
@sijie @aojea
ISSUE apache#612: Make bookie recovery work with recovering multiple …
675da6b 
…bookies

Descriptions of the changes in this PR:

This is a change ported from twitter branch.

- Enable recovering multiple bookies in bookie shell
- Add a unit test for BookieShell.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes apache#714 from sijie/recover_command_fix, closes apache#612
athanatos pushed a commit to athanatos/bookkeeper that referenced this issue Jan 25, 2019
@hanm
ZOOKEEPER-3131: Remove watcher when session closed in NettyServerCnxn
95557a3 
Currently, it doesn't remove itself from ZK server when the cnxn is closed, which
will leak watchers, close it to make it align with NIO implementation.

Author: Fangmin Lyu <allenlyu@fb.com>

Reviewers: hanm, anmolnar, nkalmar

Closes apache#612 from lvfangmin/ZOOKEEPER-3131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sijie sijie

Labels
area/tools release/4.6.0 type/feature
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
3 participants
@ivankelly @sijie @jiazhai