Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests failure with BKMetadataVersionException #726

Closed
jiazhai opened this issue Nov 15, 2017 · 1 comment
Closed

Unit Tests failure with BKMetadataVersionException #726

jiazhai opened this issue Nov 15, 2017 · 1 comment
Assignees
@sijie
Labels
area/client area/metadata release/4.6.0 type/bug
Milestone
4.6.0

Comments

@jiazhai
Copy link
Member

jiazhai commented Nov 15, 2017 •
edited

BUG REPORT

  1. Please describe the issue you observed:
  • What did you do?
    Run mvn test
  • What did you expect to see?
    Expect all tests passed
  • What did you see instead?
    some tests failed, with Exception: BKMetadataVersionException
    Failure cases:
  BookieRecoveryTest.testMetadataConflictWhenDelayingEnsembleChange » BKMetadataVersion
  BookieRecoveryTest.testMetadataConflictWithRecovery » BKMetadataVersion Bad le...
  BookieRecoveryTest.testSyncBookieRecoveryToRandomBookiesCheckForDupes » BKMetadataVersion
  TestDelayEnsembleChange.testChangeEnsembleSecondBookieReadOnly » BKMetadataVersion
  TestWatchEnsembleChange.testWatchEnsembleChange[1] » BKMetadataVersion Bad led...
  UpdateLedgerCmdTest.testUpdateLedgersToHostname » BKMetadataVersion Bad ledger...
  UpdateLedgerOpTest.testChangeEnsembleAfterRenaming:202 » BKMetadataVersion Bad...
  UpdateLedgerOpTest.testLimitLessThanTotalLedgers » BKMetadataVersion Bad ledge...
  UpdateLedgerOpTest.testManyLedgers » BKMetadataVersion Bad ledger metadata ver...
  UpdateLedgerOpTest.testRenameWhenAddEntryInProgress » BKMetadataVersion Bad le...

get one stack example from TestWatchEnsembleChange.testWatchEnsembleChange here:

 2017-11-15 13:00:11,838 - ERROR - [BookKeeperClientWorker-OrderedSafeExecutor-0-0:PendingAddOp@354] - Write of ledger entry to quorum failed: L0 E10
 org.apache.bookkeeper.client.BKException$BKMetadataVersionException: Bad ledger metadata version
     at org.apache.bookkeeper.client.SyncCallbackUtils.finish(SyncCallbackUtils.java:68)
     at org.apache.bookkeeper.client.SyncCallbackUtils$SyncAddCallback.addComplete(SyncCallbackUtils.java:264)
     at org.apache.bookkeeper.client.PendingAddOp.submitCallback(PendingAddOp.java:359)
     at org.apache.bookkeeper.client.LedgerHandle.errorOutPendingAdds(LedgerHandle.java:1300)
     at org.apache.bookkeeper.client.LedgerHandle$3.safeRun(LedgerHandle.java:427)
     at org.apache.bookkeeper.common.util.SafeRunnable.run(SafeRunnable.java:36)
     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
     at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
     at java.lang.Thread.run(Thread.java:748)
@jiazhai
Copy link
Member Author

jiazhai commented Nov 15, 2017

Thanks for @sijie's help, this may related changes in #718

@sijie sijie mentioned this issue Nov 15, 2017
Closed
@sijie sijie self-assigned this Nov 16, 2017
@jiazhai jiazhai added this to the 4.7.0 milestone Nov 16, 2017
jiazhai pushed a commit that referenced this issue Nov 16, 2017
@sijie @jiazhai
ISSUE #726: Unit Tests failure with BKMetadataVersionException
970363c 
Descriptions of the changes in this PR:

Problem:

The problem is introduced after making storing ctime optional. the verification become inconsistent because the way how ctime was assigned and compared. It causes the test cases failing in #726

Solution:

This change is to change `isConflict` to ignore comparing ctime if client disables storing system time as ctime.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes #730 from sijie/fix_ctime_issue, closes #726

(cherry picked from commit c9a150b)
Signed-off-by: Jia Zhai <zhaijia@apache.org>
@sijie sijie modified the milestones: 4.7.0, 4.6.0 Nov 22, 2017
philipsu522 pushed a commit to philipsu522/bookkeeper that referenced this issue Dec 8, 2017
@sijie
ISSUE apache#726: Unit Tests failure with BKMetadataVersionException
51ad022 
Descriptions of the changes in this PR:

Problem:

The problem is introduced after making storing ctime optional. the verification become inconsistent because the way how ctime was assigned and compared. It causes the test cases failing in apache#726

Solution:

This change is to change `isConflict` to ignore comparing ctime if client disables storing system time as ctime.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes apache#730 from sijie/fix_ctime_issue, closes apache#726
aojea pushed a commit to aojea/bookkeeper that referenced this issue Dec 16, 2017
@sijie @aojea
ISSUE apache#726: Unit Tests failure with BKMetadataVersionException
b49f929 
Descriptions of the changes in this PR:

Problem:

The problem is introduced after making storing ctime optional. the verification become inconsistent because the way how ctime was assigned and compared. It causes the test cases failing in apache#726

Solution:

This change is to change `isConflict` to ignore comparing ctime if client disables storing system time as ctime.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>

This closes apache#730 from sijie/fix_ctime_issue, closes apache#726
athanatos pushed a commit to athanatos/bookkeeper that referenced this issue Jan 25, 2019
@akkumar @lvfangmin
ZOOKEEPER-3205: Add test cases for jute
f4667d6 
Adding some test cases for o.a.jute BinaryInputArchive .  Issue ZOOKEEPER-3205 contains the patch as well.

Author: Karthik K <karthiknetworklink@gmail.com>

Reviewers: fangmin@apache.org, eolivelli@apache.org

Closes apache#726 from akkumar/jutetest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sijie sijie

Labels
area/client area/metadata release/4.6.0 type/bug
Projects
None yet
Milestone
4.6.0
Development

No branches or pull requests
2 participants
@sijie @jiazhai