Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP-21: New API close inconsistencies #789

Closed
ivankelly opened this issue Nov 29, 2017 · 1 comment
Closed

BP-21: New API close inconsistencies #789

ivankelly opened this issue Nov 29, 2017 · 1 comment
Labels
BP status/notaproblem

Comments

@ivankelly
Copy link
Contributor

ivankelly commented Nov 29, 2017 •
edited by sijie

Bookkeeper proposal

This is the master ticket for tracking BP-21

There are a couple of inconsistencies, overloading of meaning and general shortcomings of how close is accessed in the new api (and also in the old api, but I'm not proposing we change that).

This BP will describe the shortcomings and suggest solutions.

Proposal PR - #790
@ivankelly ivankelly changed the title BP-21: Improve new API close behaviour BP-21: New API close inconsistencies Nov 29, 2017
@ivankelly ivankelly added the BP label Dec 5, 2017
@sijie
Copy link
Member

sijie commented Dec 6, 2017

Close this BP as status/notaproblem for now. The proposal content is merged.

@sijie sijie closed this as completed Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BP status/notaproblem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivankelly @sijie