Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.apache.bookkeeper.tests.shaded.BookKeeperServerShadedArtifactTest.testProtobufIsShaded failed #935

Closed
sijie opened this issue Jan 3, 2018 · 2 comments
Closed

org.apache.bookkeeper.tests.shaded.BookKeeperServerShadedArtifactTest.testProtobufIsShaded failed #935

sijie opened this issue Jan 3, 2018 · 2 comments
Assignees
@sijie
Labels
area/tools release/4.7.0 type/improvement
Milestone
4.7.0

Comments

@sijie
Copy link
Member

sijie commented Jan 3, 2018

BUG REPORT

  1. Please describe the issue you observed:
  • What did you do?

run mvn install in current master

  • What did you expect to see?

it should complete successfully.

  • What did you see instead?

The command failed with

Error Message
Expected exception: java.lang.ClassNotFoundException
Stacktrace
java.lang.AssertionError: Expected exception: java.lang.ClassNotFoundException

The problem is introduced due to merging #856 after merging #928. Because pulsar-checksum depends on guava, which is not included in the changes of #928.
@sijie sijie added this to the 4.7.0 milestone Jan 3, 2018
athanatos pushed a commit to athanatos/bookkeeper that referenced this issue Jan 5, 2018
ISSUE apache#935: tests/bookkeeeper-server-shaded-*test/pom.xml: excl…
93abe60 
…ude pulsar

This prevents the test artifact from pulling in guava via pulsar.

Signed-off-by: Samuel Just <sjust@salesforce.com>
@athanatos
Copy link

I pushed a PR for this one.

@sijie
Copy link
Member Author

sijie commented Jan 5, 2018

@athanatos this is fixed in #937 , because the problem was introduced by pulsar-checksum which will be substituted to imported circe-checksum in #937. I didn't merge #937 because of current CI job doesn't handle well with paths containing spaces, which I have a fix in #952 .

@sijie sijie mentioned this issue Jan 5, 2018
Closed
@sijie sijie self-assigned this Jan 7, 2018
@sijie sijie closed this as completed in 1e2c24b Jan 7, 2018
@sijie sijie mentioned this issue Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sijie sijie

Labels
area/tools release/4.7.0 type/improvement
Projects
None yet
Milestone
4.7.0
Development

No branches or pull requests
2 participants
@athanatos @sijie