Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1078: use CachingStatsProvider underly PrometheusMetricsProvider #1081

Closed
wants to merge 1 commit into from
Closed

Issue 1078: use CachingStatsProvider underly PrometheusMetricsProvider #1081

wants to merge 1 commit into from

Conversation

jiazhai
Copy link
Member

@jiazhai jiazhai commented Jan 30, 2018

Descriptions of the changes in this PR:

  • add CachingStatsProvider to wrapper PrometheusMetricsProvider;
  • add test verify the cache.

Master Issue: #1078

merlimat
merlimat approved these changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sijie sijie added this to the 4.7.0 milestone Jan 30, 2018
@sijie sijie closed this in d5dffc4 Jan 30, 2018
sijie pushed a commit that referenced this pull request Jan 30, 2018
@jiazhai @sijie
ISSUE #1078: use CachingStatsProvider underly PrometheusMetricsProvider
3ffae0d 
Descriptions of the changes in this PR:
- add CachingStatsProvider to wrapper PrometheusMetricsProvider;
- add test verify the cache.

Master Issue: #1078

Author: Jia Zhai <zhaijia@apache.org>

Reviewers: Sijie Guo <sijie@apache.org>, Matteo Merli <mmerli@apache.org>

This closes #1081 from jiazhai/issue-1078, closes #1078

(cherry picked from commit d5dffc4)
Signed-off-by: Sijie Guo <sijie@apache.org>
sijie pushed a commit that referenced this pull request Jan 30, 2018
@jiazhai @sijie
ISSUE #1078: use CachingStatsProvider underly PrometheusMetricsProvider
c2d7731 
Descriptions of the changes in this PR:
- add CachingStatsProvider to wrapper PrometheusMetricsProvider;
- add test verify the cache.

Master Issue: #1078

Author: Jia Zhai <zhaijia@apache.org>

Reviewers: Sijie Guo <sijie@apache.org>, Matteo Merli <mmerli@apache.org>

This closes #1081 from jiazhai/issue-1078, closes #1078

(cherry picked from commit d5dffc4)
Signed-off-by: Sijie Guo <sijie@apache.org>
sijie pushed a commit to sijie/bookkeeper that referenced this pull request Jan 30, 2018
@jiazhai @sijie
ISSUE apache#1078: use CachingStatsProvider underly PrometheusMetrics…
7cbfbc4 
…Provider

Descriptions of the changes in this PR:
- add CachingStatsProvider to wrapper PrometheusMetricsProvider;
- add test verify the cache.

Master Issue: apache#1078

Author: Jia Zhai <zhaijia@apache.org>

Reviewers: Sijie Guo <sijie@apache.org>, Matteo Merli <mmerli@apache.org>

This closes apache#1081 from jiazhai/issue-1078, closes apache#1078
@sijie sijie mentioned this pull request Jan 30, 2018
Closed
merlimat pushed a commit to merlimat/bookkeeper that referenced this pull request Feb 15, 2018
@jiazhai @merlimat
ISSUE apache#1078: use CachingStatsProvider underly PrometheusMetrics…
82b86f8 
…Provider

Descriptions of the changes in this PR:
- add CachingStatsProvider to wrapper PrometheusMetricsProvider;
- add test verify the cache.

Master Issue: apache#1078

Author: Jia Zhai <zhaijia@apache.org>

Reviewers: Sijie Guo <sijie@apache.org>, Matteo Merli <mmerli@apache.org>

This closes apache#1081 from jiazhai/issue-1078, closes apache#1078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

Assignees

@jiazhai jiazhai

Labels
area/stats release/4.5.2 release/4.6.2 release/4.7.0 type/improvement
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiazhai @merlimat @sijie