Use loopback network interface for testcases. #1097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Feb 1, 2018
- tests would be more reliable irrespective of the environment, if the loopback address is used in testsuites. - unless loopback address is set explicitly, in my env (while on company's VPN), UpdateCookieCmdTest is failing most of the times. - currently allowLoopback is set to true in BookKeeperClusterTestCase, it doesn't make Bookies to use loopback interface address. - loopback network interface should be set explicitly as listening interface to use loopback address.
reddycharan
force-pushed
the
loopbackaddress
branch
from
43ae8a4
to
c25ebe1
Compare
|
lgtm |
jiazhai
approved these changes
Feb 2, 2018
|
retest this please |
|
I ran locally AuditorLedgerCheckerTest and BookieClientTest multiple times and they are running fine. Not sure why tests failed here. Also different tests failed in Java8 and Java9 build. |
|
@sijie I made changes to the initial commit and replaced the initial commit. Can you sign-off on this. Thanks. |
|
@reddycharan I don't think the failures are related. |
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Feb 19, 2018
*Problem* Issue apache#1097 introduced using `loopback` nic as the bookie server identifier. However a few test cases construct the bookie socket address using `InetAddress.getLocalHost()` and the bookie port. This bookie socket address can be different from the actual socket address that a bookie is advertising to zookeeper. It will cause test cases fail with some network settings. *Solution* This change use `BookieServer#getLocalAddress()` to retrieve the actual bookie socket address. so it would respect to the server configuration and use the right socket address in the test.
sijie
added a commit
that referenced
this pull request
Feb 20, 2018
Descriptions of the changes in this PR: *Problem* Issue #1097 introduced using `loopback` nic as the bookie server identifier. However a few test cases construct the bookie socket address using `InetAddress.getLocalHost()` and the bookie port. This bookie socket address can be different from the actual socket address that a bookie is advertising to zookeeper. It will cause test cases fail with certain network settings. *Solution* This change use `BookieServer#getLocalAddress()` to retrieve the actual bookie socket address. so it would respect to the server configuration and use the right socket address in the test. Author: Sijie Guo <sijie@apache.org> Reviewers: Charan Reddy Guttapalem <reddycharan18@gmail.com>, Enrico Olivelli <eolivelli@gmail.com> This closes #1172 from sijie/use_bookie_server_get_local_address
sijie
added a commit
that referenced
this pull request
Feb 21, 2018
Descriptions of the changes in this PR: *Problem* in GSSAPIBookKeeperTest, `InetAddress.getLocalHost().getHostName()` was used for adding principle to kdc keytab. However in the tests, it uses advertisedAddress (introduced by #1097). So it causes authentication failed because server can't be found. *Solution* Change to use `Bookie. getBookieAddress(..)` to get the real hostname used by bookie for adding keytab entries. Author: Sijie Guo <sijie@apache.org> Reviewers: Charan Reddy Guttapalem <reddycharan18@gmail.com>, Enrico Olivelli <eolivelli@gmail.com> This closes #1191 from sijie/fix_gssapibookkeeper_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
UpdateCookieCmdTest is failing most of the times.
but it doesn't make Bookies to use loopback interface address.
listening interface to use loopback address.
Note: