Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging on ledger dirs monitor to avoid log flooding #1322

Closed
wants to merge 1 commit into from

Conversation

sijie
Copy link
Member

@sijie sijie commented Apr 8, 2018

Descriptions of the changes in this PR:

Problem

When a bookie is in readonly mode, the ledger dirs monitor will keep check the disk usage and generate tons of logs if the disk usage is unchanged. This makes debugging much difficult.

Solution

  • Improve the logging logic in ledger dirs monitor to only log changes when disk usage is changed.
  • Disable logging on checking threshold for high priority writes. Only log changes when high priority writes availability is changed.

Result

This reduces the logging when a bookie is outage in readonly mode.

@sijie sijie added this to the 4.7.0 milestone Apr 8, 2018
@sijie sijie self-assigned this Apr 8, 2018
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.
The change looks good

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@yzang yzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sijie sijie closed this in c760c56 Apr 9, 2018
@sijie sijie deleted the improve_monitor_logging branch July 16, 2018 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants