[release-4.7.0] update BC tests #1352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change should be cherry-picked to branch-4.7 on merging. |
eolivelli
reviewed
Apr 17, 2018
There was a problem hiding this comment.
Can't we drop 4.6.0 and 4.6.1 and keep only latest point release per branch?
Cc @ivankelly
|
No. The BC tests are testing all versions. |
|
retest this please // 4.7.0 image is built |
|
retest this please // saw disk full.. |
|
retest this please |
|
retest this please // IT CI passed but java 9 CI failed due to timeout |
|
retest this please |
1 similar comment
|
retest this please |
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
Apr 24, 2018
Descriptions of the changes in this PR: add 4.6.2 and 4.7.0 to BC tests list Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None> This closes apache#1352 from sijie/update_bc_tests
sijie
added a commit
to sijie/bookkeeper
that referenced
this pull request
May 3, 2018
*Motivation* apache#1352 update the BC tests to include newer versions, however it removes the flags that used for 4.6.0 to handle badly shutdown. This change makes the BC tests become very flaky. *Solution* - apply `badlyshutdown` flag to both from 4.6.0 to 4.6.1 and from 4.6.1 to 4.6.2 upgrade
Closed
sijie
added a commit
that referenced
this pull request
May 3, 2018
Descriptions of the changes in this PR: *Motivation* #1352 update the BC tests to include newer versions, however it removes the flags that used for 4.6.0 to handle badly shutdown. This change makes the BC tests become very flaky. *Solution* - apply `badlyshutdown` flag to both from 4.6.0 to 4.6.1 and from 4.6.1 to 4.6.2 upgrade Author: Sijie Guo <sijie@apache.org> Reviewers: Matteo Merli <mmerli@apache.org> This closes #1386 from sijie/vagrant_files
sijie
added a commit
that referenced
this pull request
May 3, 2018
Descriptions of the changes in this PR: *Motivation* #1352 update the BC tests to include newer versions, however it removes the flags that used for 4.6.0 to handle badly shutdown. This change makes the BC tests become very flaky. *Solution* - apply `badlyshutdown` flag to both from 4.6.0 to 4.6.1 and from 4.6.1 to 4.6.2 upgrade Author: Sijie Guo <sijie@apache.org> Reviewers: Matteo Merli <mmerli@apache.org> This closes #1386 from sijie/vagrant_files (cherry picked from commit 92525c2) Signed-off-by: Sijie Guo <sijie@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
add 4.6.2 and 4.7.0 to BC tests list