Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RocksDB to 5.13.1 #1466

Closed
wants to merge 5 commits into from
Closed

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Jun 1, 2018

Upgrade RocksDB version to include a fix for empty SSTs written by flushing with deleteRange() operations that cause assertion failures on DB open.

Description can be found at : facebook/rocksdb#2717

@merlimat merlimat added this to the 4.8.0 milestone Jun 1, 2018
@merlimat merlimat self-assigned this Jun 1, 2018
@merlimat merlimat requested review from ivankelly and sijie June 1, 2018 06:18
@ivankelly
Copy link
Contributor

A class that we use has been deprecated, so that needs to be fixed before any build will run.

@sijie
Copy link
Member

sijie commented Jun 2, 2018

@merlimat do you mind addressing the CI failures? so I can include this for 4.7.1 release.

@merlimat
Copy link
Contributor Author

merlimat commented Jun 3, 2018

@sijie fixed compile errors

@sijie
Copy link
Member

sijie commented Jun 3, 2018

@merlimat I think there are some compilation errors for table service as well. I will try to fix them and push to this branch.

@sijie
Copy link
Member

sijie commented Jun 4, 2018

retest this please

1 similar comment
@sijie
Copy link
Member

sijie commented Jun 4, 2018

retest this please

@sijie
Copy link
Member

sijie commented Jun 5, 2018

rerun integration tests

@eolivelli
Copy link
Contributor

Do we need some note in the upgrade procedure?
Is it possible to downgrade to previous version or once the upgrade to 4.7.1/4.8.0 it is not possible to rollback?

@sijie @merlimat

@sijie
Copy link
Member

sijie commented Jun 5, 2018

@eolivelli I don't think there is any disk format changes. @merlimat can correct me if I am wrong.

@sijie
Copy link
Member

sijie commented Jun 5, 2018

run integration tests

@sijie
Copy link
Member

sijie commented Jun 5, 2018

It seems integration tests keep timed out on H30 node.

@sijie
Copy link
Member

sijie commented Jun 5, 2018

rick it

@sijie
Copy link
Member

sijie commented Jun 5, 2018

rerun integration tests

@asfgit
Copy link

asfgit commented Jun 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper_precommit_replication_tests/3/

@asfgit
Copy link

asfgit commented Jun 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper_precommit_tls_tests/3/

@asfgit
Copy link

asfgit commented Jun 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper_precommit_bookie_tests/3/

@asfgit
Copy link

asfgit commented Jun 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper_precommit_remaining_tests/3/

@asfgit
Copy link

asfgit commented Jun 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper_precommit_client_tests/3/

@asfgit
Copy link

asfgit commented Jun 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/bookkeeper_precommit_integrationtests/864/

@sijie
Copy link
Member

sijie commented Jun 5, 2018

not sure why the integration tests keep failing. there is no a successful run for this PR.

https://builds.apache.org/job/bookkeeper_precommit_integrationtests/

rerun integration tests

@sijie
Copy link
Member

sijie commented Jun 5, 2018

(I need this PR to be included in 4.7.1, in order to align the rocksdb version used for pulsar 2.1)

@sijie
Copy link
Member

sijie commented Jun 5, 2018

finally ... the integration tests passed. once the remaining 2 passed. will merge it to master and branch-4.7.

@sijie
Copy link
Member

sijie commented Jun 6, 2018

rebuild java8

@sijie
Copy link
Member

sijie commented Jun 6, 2018

All CI passed (the build java9 is a flaky one)

@sijie
Copy link
Member

sijie commented Jun 6, 2018

IGNORE CI

@sijie sijie added area/bookie area/tableservice changes related to table service release/4.8.0 labels Jun 6, 2018
@sijie sijie closed this in 7bbd3de Jun 6, 2018
sijie pushed a commit that referenced this pull request Jun 6, 2018
Upgrade RocksDB version to include a fix for empty SSTs written by flushing with deleteRange() operations that cause assertion failures on DB open.

Description can be found at : facebook/rocksdb#2717

Author: Matteo Merli <mmerli@apache.org>

Reviewers: Jia Zhai <None>, Sijie Guo <sijie@apache.org>

This closes #1466 from merlimat/upgrade-rocksdb

(cherry picked from commit 7bbd3de)
Signed-off-by: Sijie Guo <sijie@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants