-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade RocksDB to 5.13.1 #1466
Conversation
A class that we use has been deprecated, so that needs to be fixed before any build will run. |
@merlimat do you mind addressing the CI failures? so I can include this for 4.7.1 release. |
@sijie fixed compile errors |
@merlimat I think there are some compilation errors for table service as well. I will try to fix them and push to this branch. |
retest this please |
1 similar comment
retest this please |
rerun integration tests |
@eolivelli I don't think there is any disk format changes. @merlimat can correct me if I am wrong. |
run integration tests |
It seems integration tests keep timed out on H30 node. |
rick it |
rerun integration tests |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
not sure why the integration tests keep failing. there is no a successful run for this PR. https://builds.apache.org/job/bookkeeper_precommit_integrationtests/ rerun integration tests |
(I need this PR to be included in 4.7.1, in order to align the rocksdb version used for pulsar 2.1) |
finally ... the integration tests passed. once the remaining 2 passed. will merge it to master and branch-4.7. |
rebuild java8 |
All CI passed (the build java9 is a flaky one) |
IGNORE CI |
Upgrade RocksDB version to include a fix for empty SSTs written by flushing with deleteRange() operations that cause assertion failures on DB open. Description can be found at : facebook/rocksdb#2717 Author: Matteo Merli <mmerli@apache.org> Reviewers: Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes #1466 from merlimat/upgrade-rocksdb (cherry picked from commit 7bbd3de) Signed-off-by: Sijie Guo <sijie@apache.org>
Upgrade RocksDB version to include a fix for empty SSTs written by flushing with deleteRange() operations that cause assertion failures on DB open.
Description can be found at : facebook/rocksdb#2717