BOOKKEEPER-1061: BookieWatcher should not do ZK blocking operations from ZK async callback thread #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom ZK async callback thread
|
@athanatos FYI |
sijie
approved these changes
May 15, 2017
revans2
pushed a commit
to revans2/bookkeeper
that referenced
this pull request
Oct 11, 2017
reddycharan
pushed a commit
to reddycharan/bookkeeper
that referenced
this pull request
Aug 20, 2018
* Avoid releasing sent buffer to early in BookieClient mock If the buffer was sent to more than one bookie with the mock, it would be released after being sent to the first one. Each write should retain a refCount themselves, and then release when done. Author: Ivan Kelly <ivank@apache.org> Reviewers: Sijie Guo <sijie@apache.org> This closes apache#1598 from ivankelly/double-rel-mock * (@bug W-5344681@) Delayed write ensemble change may cause dataloss Descriptions of the changes in this PR: The Original intent of this change is to do a best-effort ensemble change. But this is not possible until the local metadata is completely immutable. Until the feature "Make LedgerMetadata Immutable apache#610" Is complete we will use handleBookieFailure() to handle delayed writes as regular bookie failures. Signed-off-by: Venkateswararao Jujjuri (JV) <vjujjurisalesforce.com> Master Issue: apache#1591 Relate Issue: apache#1395 Author: JV Jujjuri <vjujjuri@salesforce.com> Author: Ivan Kelly <ivank@apache.org> Reviewers: Ivan Kelly <ivank@apache.org>, Sijie Guo <sijie@apache.org> @Rev Sam Just@ This closes apache#1592 from jvrao/datalossbug
athanatos
pushed a commit
to athanatos/bookkeeper
that referenced
this pull request
Jan 25, 2019
…"No such device" exception The following stack trace was observed intermittently: ``` Stacktrace java.net.SocketException: No such device at java.net.NetworkInterface.isLoopback0(Native Method) at java.net.NetworkInterface.isLoopback(NetworkInterface.java:390) at org.apache.zookeeper.test.ClientPortBindTest.testBindByAddress(ClientPortBindTest.java:61) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) Standard Output ``` Proposed fix is to catch exception from isLoopback() call and skip the test in that case. Author: tedyu <yuzhihong@gmail.com> Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>, Michael Han <hanm@apache.org> Closes apache#149 from tedyu/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the BookieWatcher can get the ZK event thread stuck. This happens when a ZK blocking request is issued from a ZK callback thread.
We should decouple the blocking requests in a separate executor to avoid deadlocking ZK client.