Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide async version of markLedgerUnderreplicated for LedgerUnderreplicationManager #1619

Closed
wants to merge 4 commits into from

Commits on Aug 22, 2018

  1. Add markLedgerUnderreplicatedAsync method to LedgerUnderreplicationMa…

    …nager
    
     ### Motivation
    
    Auditor has multiple places calling sync methods in async callbacks.
    This raises the possibility hitting deadlock. Issue apache#1578 is one of the examples.
    
    After looking into the `LedgerUnderreplicationManager`, `markLedgerUnderreplicated`
    is the only interface that will be called in async callbacks. This change is
    to provide an async version of `markLedgerUnderreplicated`.
    
     ### Changes
    
    - add `markLedgerUnderreplicatedAsync` interface in `LedgerUnderreplicationManager`.
    - implement the logic of `markLedgerUnderreplicated` using async callbacks
    - use `markLedgerUnderreplicatedAsync` in the Auditor
    
    Related Issues: apache#1578
    Master Issue: apache#1617
    sijie committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    fb6a538 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2018

  1. Configuration menu
    Copy the full SHA
    3aef2ac View commit details
    Browse the repository at this point in the history
  2. Address Charan's comments

    sijie committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    e2759ec View commit details
    Browse the repository at this point in the history
  3. Fix the logging

    sijie committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    1d8e2c2 View commit details
    Browse the repository at this point in the history